1345626 - build error: ‘nsresult {anonymous}::KeyedHistogram::GetDataset(uint32_t*) const’ defined but not used

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Tom Tromey :tromey]

I'm on x86-64 Fedora 25, using the system gcc.

After bug 1341236 landed I see this when building:

/home/tromey/firefox-git/gecko/toolkit/components/telemetry/TelemetryHistogram.cpp:988:1: error: ‘nsresult {anonymous}::KeyedHistogram::GetDataset(uint32_t*) const’ defined but not used [-Werror=unused-function]
 KeyedHistogram::GetDataset(uint32_t* dataset) const
 ^~~~~~~~~~~~~~


Sure enough, this class is private to the file and the method in question
is not called.  Simply deleting it worked for me.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1345626 - remove KeyedHistogram::GetDataset;

Review commit: https://reviewboard.mozilla.org/r/118338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118338/

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8845121 [details]
Bug 1345626 - remove KeyedHistogram::GetDataset;

https://reviewboard.mozilla.org/r/118338/#review120424

Good catch, that slipped through in the other bug. I'm not sure why we didn't catch that with the try push tough: maybe different compiler version? Anyway, thank you!

Comment 3

[Tom Tromey :tromey]

(In reply to Alessio Placitelli [:Dexter] from comment #2)

> Good catch, that slipped through in the other bug. I'm not sure why we
> didn't catch that with the try push tough: maybe different compiler version?

I didn't look but that seems likely.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84ad1f7264d5
remove KeyedHistogram::GetDataset; r=Dexter

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/84ad1f7264d5