build error: ‘nsresult {anonymous}::KeyedHistogram::GetDataset(uint32_t*) const’ defined but not used

RESOLVED FIXED in Firefox 55

Status

()

defect
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment)

I'm on x86-64 Fedora 25, using the system gcc.

After bug 1341236 landed I see this when building:

/home/tromey/firefox-git/gecko/toolkit/components/telemetry/TelemetryHistogram.cpp:988:1: error: ‘nsresult {anonymous}::KeyedHistogram::GetDataset(uint32_t*) const’ defined but not used [-Werror=unused-function]
 KeyedHistogram::GetDataset(uint32_t* dataset) const
 ^~~~~~~~~~~~~~


Sure enough, this class is private to the file and the method in question
is not called.  Simply deleting it worked for me.
Assignee: nobody → ttromey
Comment on attachment 8845121 [details]
Bug 1345626 - remove KeyedHistogram::GetDataset;

https://reviewboard.mozilla.org/r/118338/#review120424

Good catch, that slipped through in the other bug. I'm not sure why we didn't catch that with the try push tough: maybe different compiler version? Anyway, thank you!
Attachment #8845121 - Flags: review?(alessio.placitelli) → review+
Priority: -- → P3
Summary: build failure after bug 1341236 → build error: ‘nsresult {anonymous}::KeyedHistogram::GetDataset(uint32_t*) const’ defined but not used
Whiteboard: [measurement:client]
(In reply to Alessio Placitelli [:Dexter] from comment #2)

> Good catch, that slipped through in the other bug. I'm not sure why we
> didn't catch that with the try push tough: maybe different compiler version?

I didn't look but that seems likely.
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84ad1f7264d5
remove KeyedHistogram::GetDataset; r=Dexter
https://hg.mozilla.org/mozilla-central/rev/84ad1f7264d5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.