1345650 - Self-support breaks automated tests with the changed URL from bug 1326225

Status: NEW

(Firefox :: General, enhancement)

Description

[:Gijs (he/him)]

Per bug 1344670, it looks like using example.com doesn't quite work for self-support code.

:mythmon, why did we change the URL for self-support as well, in bug 1326225? What does the %server(s) stuff even do (does it do *something*? Or just break the fetch but nothing else?).

We'll need to update this to make sure 54 going to beta won't hit bug 1344670 again.

Comment 1

[:Gijs (he/him)]

Hrmpf, no tracking flags for the SHIELD product. :-(

Comment 2

[Michael Cooper [:mythmon]]

As I understand it, there is a test server running on localhost that can be accessed via a hostname that is available in prefs as |%(server)s|. That test server is not accessible over https. Both the old self-repair [1] and the new recipe-client [2] require their urls to be https, and won't accept http. I was told that the easy way to get an https url was to use example.com, which would point to the same server as |%(server)s|.

That's all I know about that. I'm not sure what the right thing to do is here. To me it sounds like the WPT tests from bug 1344670 should probably support example.com, like mochitests, or disable self-support and the recipe-client.

[0]: https://dxr.mozilla.org/mozilla-central/rev/58753259bfeb3b818eac7870871b0aae1f8de64a/browser/modules/SelfSupportBackend.jsm#247-250
[1]: https://dxr.mozilla.org/mozilla-central/rev/58753259bfeb3b818eac7870871b0aae1f8de64a/browser/extensions/shield-recipe-client/lib/RecipeRunner.jsm#53-56

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Mike Cooper [:mythmon] from comment #2)
> That's all I know about that. I'm not sure what the right thing to do is
> here. To me it sounds like the WPT tests from bug 1344670 should probably
> support example.com, like mochitests, or disable self-support and the
> recipe-client.

James, would anything stop us from disabling both the self-support and recipe-client? I don't think that any of the tests are dependent on those.

Comment 4

[James Graham [:jgraham]]

No, afaik that should be fine (I assume these are both frontend features that don't affect the platform).

Comment 5

[Gerry Chang [:gchang]]

Per comment #0, track 54+ for the issue of bug 1344670.

Comment 6

[Phil Ringnalda (:philor)]

I'd think a considerably better idea would be to set the pref for extensions.shield-recipe-client.api_url to a working value in browser_RecipeRunner.js, the single place which currently cares anything about what the URL is or whether it works at all, rather than disable something we ship on a considerable chunk of our tests.

Comment 7

[Phil Ringnalda (:philor)]

And we're out of time yet again for actual reviewed patches written by people who understand what's going on and how things should be done.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/44f6061a5dc6

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/f71d6c41c2eee4e5af80bef4a413d7a7dff3aa46
Bug 1345650 - use https://%(server)s/ for shield/self-support URLs to not break web-platform-tests on beta, and set shield-recipe-client.api_url to a working value in browser_RecipeRunner.js

https://github.com/mozilla/normandy/commit/0386d6ae4d7c1ba4d5d7cb27b24181f2dcd5a3ea
Merge pull request #694 from mythmon/bug-1345650-backport

Bug 1345650 - Backport preference fix

Comment 10

[Tiffany Phillips]

Attachment: same problem

Thanks from tigreuharpi1981.