Closed Bug 1345712 Opened 8 years ago Closed 8 years ago

Youtube video is not scaled correctly when zoom is changed

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla55

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(3 files, 7 obsolete files)

patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 1.04 KB, patch		Details \| Diff \| Splinter Review
patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 4.26 KB, patch		Details \| Diff \| Splinter Review
patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 4.30 KB, patch	jrmuizel : review+	Details \| Diff \| Splinter Review
patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 9.32 KB, patch	sotaro : review+	Details \| Diff \| Splinter Review
patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 9.32 KB, patch	sotaro : review+	Details \| Diff \| Splinter Review
patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 9.28 KB, patch	sotaro : review+	Details \| Diff \| Splinter Review
patch - Add ScaleMode handling to WebRenderImageLayer 8 years ago Sotaro Ikeda [:sotaro] 8.13 KB, patch	sotaro : review+	Details \| Diff \| Splinter Review
patch - Fix rebasing failure 8 years ago Sotaro Ikeda [:sotaro] 1.21 KB, patch	sotaro : review+	Details \| Diff \| Splinter Review
patch - Fix rebasing failure part 2 8 years ago Sotaro Ikeda [:sotaro] 1004 bytes, patch		Details \| Diff \| Splinter Review
patch - Fix rebasing failure part 2 8 years ago Sotaro Ikeda [:sotaro] 7.33 KB, patch	sotaro : review+	Details \| Diff \| Splinter Review

Sotaro Ikeda [:sotaro]

Assignee

Description

•

8 years ago

If zoom is changed during playing a video on youtube. The video is not scaled correctly.

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Assignee: nobody → sotaro.ikeda.g

Blocks: webrender

Sotaro Ikeda [:sotaro]

Assignee

Comment 1

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer (obsolete) — Details — Splinter Review

Sotaro Ikeda [:sotaro]

Assignee

Comment 2

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=adb36a6bb998bdf723ba41af8fb3ab28a5608ed5

Sotaro Ikeda [:sotaro]

Assignee

Comment 3

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer (obsolete) — Details — Splinter Review

Attachment #8845208 - Attachment is obsolete: true

Sotaro Ikeda [:sotaro]

Assignee

Comment 4

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb65861da9af1a379e82fb46b3cc290f3f4af683

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Attachment #8845252 - Flags: review?(jmuizelaar)

Sotaro Ikeda [:sotaro]

Assignee

Comment 5

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer (obsolete) — Details — Splinter Review

Attachment #8845252 - Attachment is obsolete: true

Attachment #8845252 - Flags: review?(jmuizelaar)

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Attachment #8845673 - Flags: review?(jmuizelaar)

Jeff Muizelaar [:jrmuizel]

Updated

•

8 years ago

Attachment #8845673 - Flags: review?(jmuizelaar) → review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 6

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abd106c5bf2219a5ff23b02719c628db71f8c5a9

Sotaro Ikeda [:sotaro]

Assignee

Comment 7

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer (obsolete) — Details — Splinter Review

Update reftest.list

Attachment #8845673 - Attachment is obsolete: true

Attachment #8845684 - Flags: review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 8

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer (obsolete) — Details — Splinter Review

Attachment #8845684 - Attachment is obsolete: true

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Attachment #8845687 - Flags: review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 9

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer (obsolete) — Details — Splinter Review

Rebased.

Attachment #8845687 - Attachment is obsolete: true

Attachment #8845717 - Flags: review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 10

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d88c82ab27f02d55f50976f4819fac7461ed4b97

Pulsebot

Comment 11

•

8 years ago

Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/85041e579ef1
Add ScaleMode handling to WebRenderImageLayer r=jrmuizel

Status: NEW → RESOLVED

Closed: 8 years ago

Resolution: --- → FIXED

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

Sotaro Ikeda [:sotaro]

Assignee

Comment 12

•

8 years ago

Backout for now. Changed before my push seemed to change reftest result.
  https://hg.mozilla.org/projects/graphics/rev/c633d1ffd538

Sotaro Ikeda [:sotaro]

Assignee

Comment 13

•

8 years ago

Attached patch patch - Add ScaleMode handling to WebRenderImageLayer — Details — Splinter Review

Attachment #8845717 - Attachment is obsolete: true

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Attachment #8845797 - Flags: review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 14

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c01efa82daf839fa1a12248f81cd35dc87504b08

Pulsebot

Comment 15

•

8 years ago

Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/060bdd109602
Add ScaleMode handling to WebRenderImageLaye r=jrmuizel

Status: REOPENED → RESOLVED

Closed: 8 years ago → 8 years ago

Resolution: --- → FIXED

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

Sotaro Ikeda [:sotaro]

Assignee

Comment 16

•

8 years ago

Hmm, I made mistake during rebasing the patch:(

Sotaro Ikeda [:sotaro]

Assignee

Comment 17

•

8 years ago

From the investigation, a regression of scrolling video is not related to this bug.

Status: REOPENED → RESOLVED

Closed: 8 years ago → 8 years ago

Resolution: --- → FIXED

Sotaro Ikeda [:sotaro]

Assignee

Updated

•

8 years ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

Sotaro Ikeda [:sotaro]

Assignee

Comment 18

•

8 years ago

Attached patch patch - Fix rebasing failure — Details — Splinter Review

Attachment #8846480 - Flags: review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 19

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11ea1eea0a5074550244d272585fee918bb67075

Pulsebot

Comment 20

•

8 years ago

Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/df803a096e8d
Fix rebasing failure r=jrmuizel

Status: REOPENED → RESOLVED

Closed: 8 years ago → 8 years ago

Resolution: --- → FIXED

Sotaro Ikeda [:sotaro]

Assignee

Comment 21

•

8 years ago

Attached patch patch - Fix rebasing failure part 2 (obsolete) — Details — Splinter Review

Sotaro Ikeda [:sotaro]

Assignee

Comment 22

•

8 years ago

Attached patch patch - Fix rebasing failure part 2 — Details — Splinter Review

Attachment #8846617 - Attachment is obsolete: true

Attachment #8846655 - Flags: review+

Sotaro Ikeda [:sotaro]

Assignee

Comment 23

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7807a0c203a433aa0f2c951ad9030728eef17ce0

Pulsebot

Comment 24

•

8 years ago

Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/7f34eb94467b
Fix rebasing failure part 2 r=jrmuizel

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Comment 25

•

8 years ago

https://hg.mozilla.org/mozilla-central/rev/85041e579ef1
then backout: https://hg.mozilla.org/mozilla-central/rev/c633d1ffd538

https://hg.mozilla.org/mozilla-central/rev/060bdd109602
https://hg.mozilla.org/mozilla-central/rev/df803a096e8d
https://hg.mozilla.org/mozilla-central/rev/7f34eb94467b

Target Milestone: --- → mozilla55

You need to log in before you can comment on or make changes to this bug.