1345712 - Youtube video is not scaled correctly when zoom is changed

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

If zoom is changed during playing a video on youtube. The video is not scaled correctly.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=adb36a6bb998bdf723ba41af8fb3ab28a5608ed5

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb65861da9af1a379e82fb46b3cc290f3f4af683

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=abd106c5bf2219a5ff23b02719c628db71f8c5a9

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Update reftest.list

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Rebased.

Comment 10

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d88c82ab27f02d55f50976f4819fac7461ed4b97

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/85041e579ef1
Add ScaleMode handling to WebRenderImageLayer r=jrmuizel

Comment 12

[Sotaro Ikeda [:sotaro]]

Backout for now. Changed before my push seemed to change reftest result.
  https://hg.mozilla.org/projects/graphics/rev/c633d1ffd538

Comment 13

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add ScaleMode handling to WebRenderImageLayer

Comment 14

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c01efa82daf839fa1a12248f81cd35dc87504b08

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/060bdd109602
Add ScaleMode handling to WebRenderImageLaye r=jrmuizel

Comment 16

[Sotaro Ikeda [:sotaro]]

Hmm, I made mistake during rebasing the patch:(

Comment 17

[Sotaro Ikeda [:sotaro]]

From the investigation, a regression of scrolling video is not related to this bug.

Comment 18

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix rebasing failure

Comment 19

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11ea1eea0a5074550244d272585fee918bb67075

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/df803a096e8d
Fix rebasing failure r=jrmuizel

Comment 21

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix rebasing failure part 2

Comment 22

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix rebasing failure part 2

Comment 23

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7807a0c203a433aa0f2c951ad9030728eef17ce0

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/7f34eb94467b
Fix rebasing failure part 2 r=jrmuizel

Comment 25

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/85041e579ef1
then backout: https://hg.mozilla.org/mozilla-central/rev/c633d1ffd538

https://hg.mozilla.org/mozilla-central/rev/060bdd109602
https://hg.mozilla.org/mozilla-central/rev/df803a096e8d
https://hg.mozilla.org/mozilla-central/rev/7f34eb94467b