Closed Bug 1345733 Opened 8 years ago Closed 8 years ago

Intermittent dom/tests/browser/browser_largeAllocation_non_win32.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nika)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Priority: -- → P5
The intermittent failure rate rose up. Would you be able to take a look, Michael?
Flags: needinfo?(michael)
From the occurrences appearing in the orangefactor link, it looks like this timeout is only occurring on 32-bit linux builds. In addition, it appears as though the problem is just that process creation, especially spamming it like is done in this test, is really slow. In the test which is timing out we create at least 14 new content processes. I'm inclined to request a longer timeout (Currently it's only requestLongerTimeout(2), so I could probably bump it up to 4), or disable the expensive large allocation force-enable tests on linux32 (as we never actually respect the Large-Allocation header in 32-bit builds. The disadvantage of disabling here would be that if we decide in the future we want to respect the header on all 32-bit platforms, we won't have testing.
Flags: needinfo?(michael)
Trying a longer timeout first sounds good.
Priority: -- → P2
Assignee: nobody → michael
Oops, forgot to attach this.
Attachment #8912004 - Flags: review?(bugs)
Attachment #8912004 - Flags: review?(bugs) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/827357e7c274 Increase timeout for large allocation tests, r=smaug
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: