1345762 - Rename OSPreferences_unix.cpp to OSPreferences_android.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Makoto Kato [:m_kato]]

OSPreferences_unix.cpp is used on Android only, so we should rename OSPreferences_unix.cpp to *_android.cpp

Comment 1

[Makoto Kato [:m_kato]]

And we move nsAndroidCharset.cpp into intl/locale/android too.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1345762 - Rename OSPreferences_unix.cpp to OSPreferences_android.cpp.

OSPreferences_unix.cpp is used on Android only.  So we should rename it to OSPreferences_android.cpp
Also, we should create android directory into intl/locale, then move OSPreferences_android.cpp and nsAndroidCharset.cpp into it.

Review commit: https://reviewboard.mozilla.org/r/118462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118462/

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8845288 [details]
Bug 1345762 - Rename OSPreferences_unix.cpp to OSPreferences_android.cpp.

So, this looks good to me, but if I understand correctly it means that we will fail to compile on anything but android/win/mac/gtk. I'm not sure if there are any other toolkit targets in any tier, like freebsd, or things like that, but we won't have the "dummy" (which used to be unix) anymore.

I hope it's ok.

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #3)
> Comment on attachment 8845288 [details]
> Bug 1345762 - Rename OSPreferences_unix.cpp to OSPreferences_android.cpp.
> 
> So, this looks good to me, but if I understand correctly it means that we
> will fail to compile on anything but android/win/mac/gtk. I'm not sure if
> there are any other toolkit targets in any tier, like freebsd, or things
> like that, but we won't have the "dummy" (which used to be unix) anymore.
> 
> I hope it's ok.

Firefox on *BSD uses GTK widget, and current code uses OSPreferences_gtk on all *NIX except to macOS.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4015525fbebc
Rename OSPreferences_unix.cpp to OSPreferences_android.cpp. r=gandalf

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4015525fbebc