The default bug view has changed. See this FAQ.

Don't call ctrlTab.updatePreview for TabAttrModified events for the "select" attribute

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
19 days ago
18 days ago

People

(Reporter: dao, Assigned: Subhdeep Saha)

Tracking

({good-first-bug})

Trunk
Firefox 55
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [good first bug][lang=js])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

19 days ago
We currently call updatePreview when any of these tab attributes change: label, busy, image, selected

However, a "select" attribute change doesn't really affect previews, so we should remove this from the list.

The code is here: https://hg.mozilla.org/mozilla-central/annotate/58753259bfeb3b818eac7870871b0aae1f8de64a/browser/base/content/browser-ctrlTab.js#l476
(Reporter)

Updated

19 days ago
Depends on: 1342025
Comment hidden (mozreview-request)
(Reporter)

Comment 2

19 days ago
mozreview-review
Comment on attachment 8845496 [details]
Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute,

https://reviewboard.mozilla.org/r/118646/#review120558

::: commit-message-8fca4:1
(Diff revision 1)
> +Bug:1345773 Removed the 'selected' attribute from list r=dao

Please use this format:

Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao

::: browser/base/content/browser-ctrlTab.js:477
(Diff revision 1)
>      switch (event.type) {
>        case "SSWindowRestored":
>          this._initRecentlyUsedTabs();
>          break;
>        case "TabAttrModified":
>          // tab attribute modified (i.e. label, busy, image, selected)

Could you please update this comment too?

Looks good otherwise. Thanks!
Attachment #8845496 - Flags: review?(dao+bmo) → review-
(Reporter)

Updated

19 days ago
Assignee: nobody → subhdeepsaha
Comment hidden (mozreview-request)
(Reporter)

Comment 4

19 days ago
mozreview-review
Comment on attachment 8845496 [details]
Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute,

https://reviewboard.mozilla.org/r/118646/#review120566

Perfect, thanks!
Attachment #8845496 - Flags: review?(dao+bmo) → review+

Comment 5

19 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6bc677cfa1a
Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao

Comment 6

18 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c6bc677cfa1a
Status: NEW → RESOLVED
Last Resolved: 18 days ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.