Closed Bug 1345834 Opened 6 years ago Closed 6 years ago

Create a new keyed histogram for result indices, keyed by the values for result type

Categories

(Firefox :: Address Bar, enhancement, P1)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: past, Assigned: past)

References

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

Add an index-per-type histogram for awesomebar results (bug 1345834). data-review=bsmedberg
59 bytes, text/x-review-board-request
adw
: review+
Details
Screenshot of about:telemetry
78.43 KB, image/png
Details 
From bug 1334617 comment 4:

"Could we possibly turn FX_URLBAR_SELECTED_RESULT_INDEX into a keyed histogram, keyed by the values for result type, ie. URLBAR_SELECTED_RESULT_TYPES (https://dxr.mozilla.org/mozilla-central/source/browser/modules/BrowserUsageTelemetry.jsm#56)?"
Priority: -- → P1
Comment on attachment 8855901 [details]
Add an index-per-type histogram for awesomebar results (bug 1345834). data-review=bsmedberg

This is a data-r?
Bug 1334617 has more context about this change and the same people will monitor the collected data.
Attachment #8855901 - Flags: review?(benjamin)
Comment on attachment 8855901 [details]
Add an index-per-type histogram for awesomebar results (bug 1345834). data-review=bsmedberg

https://reviewboard.mozilla.org/r/127778/#review131144

LGTM
Attachment #8855901 - Flags: review?(adw) → review+
Comment on attachment 8855901 [details]
Add an index-per-type histogram for awesomebar results (bug 1345834). data-review=bsmedberg

https://reviewboard.mozilla.org/r/127778/#review131602

data-r=me
Attachment #8855901 - Flags: review?(benjamin) → review+
Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/64683f4aaa3e
Add an index-per-type histogram for awesomebar results . data-review=bsmedberg r=adw,bsmedberg
https://hg.mozilla.org/mozilla-central/rev/64683f4aaa3e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Flags: qe-verify+
QA Contact: brindusa.tot
You need to log in before you can comment on or make changes to this bug.