Closed
Bug 1345841
Opened 7 years ago
Closed 7 years ago
Stop using Maybe<const T>
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
5.50 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
We should probably not be using Maybe<const T> since we tend to end up unexpectedly invoking copy constructors - see bug 1345840. Instead we should use const Maybe<T>. In theory we might want support for the former in order to have Maybe's which can have different T's emplaced into them while the T's themselves are const, but we don't currently need that anywhere.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8845395 -
Flags: review?(mats)
|
||
Updated•7 years ago
|
Attachment #8845395 -
Flags: review?(mats) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ca1379d49df Stop using Maybe<const T>. r=mats
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5ca1379d49df
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•