1345863 - use job_try_name for toolchain, android-stuff kinds

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Follow-on from bug 1337903, where I created job_try_name and used it for the source-test kind.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1345863: set the job_try_name for all tasks governed by -j

Review commit: https://reviewboard.mozilla.org/r/135284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135284/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

@ahal, ping? should I reassign to someone else?

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8863511 [details]
Bug 1345863: set the job_try_name for all tasks governed by -j

https://reviewboard.mozilla.org/r/135284/#review141312

I can't grant r+ because I can't verify how this works! The diff references a "try_job" transform. But when I pull this changeset locally, there is no such transform defined in the repo! It feels like this changeset is part of a larger series of work. But without the parent changesets available in the review repo, I have no clue how this change fits into it.

Also, please write a commit message with more than a summary line.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Indeed, I had forgotten `hg addremove`!

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1345863: set the job_try_name for all tasks governed by -j;

We have a `unittest_try_name` for all unit test tasks, and similarly a
`talos_try_name`. The `-j` flag controls tasks known as "jobs" (although the
word has dozens of other meanings, too). Some of those set `job_try_name`, but
others do not and have special-case support in `try_option_syntax.py`. With
this change, all "jobs" set `job_try_name` and the special-case is removed.

Review commit: https://reviewboard.mozilla.org/r/138430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138430/

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8866841 [details]
Bug 1345863: set the job_try_name for all tasks governed by -j;

https://reviewboard.mozilla.org/r/138430/#review142276

Ah, this makes much more sense with the missing file present!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e89ecb5ae697
set the job_try_name for all tasks governed by -j; r=gps

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e89ecb5ae697