1345871 - Local PDF files are not loaded after a Firefox restart

Status: RESOLVED WORKSFORME

(Core :: Security: Process Sandboxing, defect)

Description

[Simona Badau, Desktop QA]

[Affected versions]:
- Firefox 53 Beta 1
- Firefox Developer Edition 54.0a2
- Nightly 55.0a1

[Affected platforms]:
- All

[Steps to reproduce]:
1. Launch Firefox
2. Open any local PDF file
3. Restart Firefox (Shift+F2 -> restart)

[Expected result]:
- After restart, the local PDF file is properly displayed

[Actual result]:
- The local PDF file is not loaded (white content). Restarting by hitting the F5 key or by clicking the Reload Current page does nothing. Clicking in the URL bar  + Enter key properly reloads the local PDF. 

[Regression range]:
Last good revision: 9307d60e21ba70f46fb47c9eb43b6b5246b7e64c
First bad revision: d31df518cb6ec920cf9ab7accb67682298f8a9f8
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9307d60e21ba70f46fb47c9eb43b6b5246b7e64c&tochange=d31df518cb6ec920cf9ab7accb67682298f8a9f8

[Additional notes]:
- Not reproducible on Firefox 52.

Comment 1

[Simona Badau, Desktop QA]

Christoph, could you please look over? Seems that one of your commits introduced this regression.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Simona B [:simonab ] from comment #0)
> [Steps to reproduce]:
> 1. Launch Firefox
> 2. Open any local PDF file
> 3. Restart Firefox (Shift+F2 -> restart)

Unfortunately I can not reproduce the issue. Most likely because I am not entirely sure what you mean by [Shift+F2 -> restart]. I tried restarting and reloading the *.pdf which always worked. I see you filed the bug 5 days ago. In the meantime I fixed a bunch of regressions that Bug 1182569 introduced. Could you try to reproduce one more time using the latest mozilla-central? Maybe one of those bug fixes fixed the problem here as well. If not I am happy to look into that in more detail if you could elaboarate on your step (3) of the STRs. Thanks for reporting!

Comment 3

[Simona Badau, Desktop QA]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #2)
> (In reply to Simona B [:simonab ] from comment #0)
> > [Steps to reproduce]:
> > 1. Launch Firefox
> > 2. Open any local PDF file
> > 3. Restart Firefox (Shift+F2 -> restart)
> 
> Unfortunately I can not reproduce the issue. Most likely because I am not
> entirely sure what you mean by [Shift+F2 -> restart]. I tried restarting and
> reloading the *.pdf which always worked. I see you filed the bug 5 days ago.
> In the meantime I fixed a bunch of regressions that Bug 1182569 introduced.
> Could you try to reproduce one more time using the latest mozilla-central?
> Maybe one of those bug fixes fixed the problem here as well. If not I am
> happy to look into that in more detail if you could elaboarate on your step
> (3) of the STRs. Thanks for reporting!

Christoph, thank you for taking the time to look into this.

Shift+F2 is the keyboard shortcut that opens the Developer Toolbar (at least on Windows and Ubuntu) and if you write restart in it and hit enter the browser is restarted. 

The issue was reproducible on Yesterday's Nightly Build (Build ID: 20170313030209), but is no longer reproducible on the latest Nightly Build (Build ID: 20170314030215). Based on this I'm marking this as Resolved Worksforme.