Closed Bug 1345889 Opened 9 years ago Closed 9 years ago

Create a dedicated library for v-c-t commitparser module

Categories

(Conduit :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mars, Assigned: mars)

Details

Attachments

(4 files)

Comment on attachment 8845461 [details] mozcommitparser: initial commit of commitparser library (bug 1345889) https://reviewboard.mozilla.org/r/118624/#review122042 Looks fine for the most part. ::: commit-message-aa672:3 (Diff revision 1) > +Initial commit of a new stand-alone library for the mozautomation commitparser module. > + > +Library still needs Python 3 conversion, style fixes, test suite fixup, and some additional packaging information. going forward can you wrap your commit message bodies at ~72 characters? thanks :) ::: mozcommitparser/LICENSE:38 (Diff revision 1) > + > +1.6. "Executable Form" > + means any form of the work other than Source Code Form. > + > +1.7. "Larger Work" > + means a work that combines Covered Software with other material, in Interesting, where did this file come from that it has a trailing whitespace... hmmm
Attachment #8845461 - Flags: review?(smacleod) → review+
Attachment #8845462 - Flags: review?(smacleod) → review+
Comment on attachment 8845463 [details] mozcommitparser: assume unicode, remove Python 2 byte handling (bug 1345889) https://reviewboard.mozilla.org/r/118628/#review122052 ::: commit-message-de248:1 (Diff revision 1) > +mozcommitparser: assume unicode, remove Python 2 byte handling (bug 1345889) r?smacleod > + > +Remove the Python 2 byte-string sniffing code and tests. Assume we are working with Python 3 unicode strings only. > + > +MozReview-Commit-ID: FrIdomnqR3D I'm not confident in this change, especially if we'd like to make this work with the current consumers at some point. Could you expand the commit-message to give me more background on how this will interact with different consumers, and why it's okay?
Attachment #8845463 - Flags: review?(smacleod)
Comment on attachment 8845464 [details] mozcommitparser: write MANIFEST.in (bug 1345889) https://reviewboard.mozilla.org/r/118630/#review122054 rubber-stamp
Attachment #8845464 - Flags: review?(smacleod) → review+
Comment on attachment 8845463 [details] mozcommitparser: assume unicode, remove Python 2 byte handling (bug 1345889) https://reviewboard.mozilla.org/r/118628/#review122052 > I'm not confident in this change, especially if we'd like to make this work with the current consumers at some point. Could you expand the commit-message to give me more background on how this will interact with different consumers, and why it's okay? The change is not designed to be backward-compatible with current consumers. The byte-sniffing code (or something like six) can be re-introduced when we re-integrate this with Python 2 and a proper tox testsuite.
Comment on attachment 8845463 [details] mozcommitparser: assume unicode, remove Python 2 byte handling (bug 1345889) https://reviewboard.mozilla.org/r/118628/#review130382 rs=me so I can autoland
Attachment #8845463 - Flags: review+
Pushed by mfogels@mozilla.com: https://hg.mozilla.org/automation/conduit/rev/63fad7300e6f mozcommitparser: initial commit of commitparser library r=smacleod https://hg.mozilla.org/automation/conduit/rev/dd63e994e6ff mozcommitparser: style fixes r=smacleod https://hg.mozilla.org/automation/conduit/rev/1722c8aaddce mozcommitparser: assume unicode, remove Python 2 byte handling r=mars https://hg.mozilla.org/automation/conduit/rev/93e9395b6435 mozcommitparser: write MANIFEST.in r=smacleod
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: