1345926 - Provide a more informative error message when cpanm is not installed

Status: UNCONFIRMED

(Bugzilla :: Bugzilla-General, defect)

Description

[Anamika_07]

Trying to set up Bugzilla, here I typed: perl checksetup.pl --cpanm and I see a weird error message! Later on asking Dylan (My Mentor), he found that cpanm is not install. so I googled and typed "sudo apt-get install cpanminus". Yay installed. If it is feasible to provide information on the error messages then the next person won't struggle with the installation. With this patch, a person will know that cpanm is not installed and the command to install. Without cpanm, the installation fails.So I feel that, it is a useful patch.

Comment 1

[Anamika_07]

Attachment: Provides information on the cpanm error i.e., cpanm not installed

Comment 2

[Dylan Hardison [:dylanAtHome]]

Comment on attachment 8845503 [details] [diff] [review]
Provides information on the cpanm error i.e., cpanm not installed

Review of attachment 8845503 [details] [diff] [review]:
-----------------------------------------------------------------

r- with some changes requested.

I'll be available during the week if you have questions.

::: checksetup.pl
@@ +90,3 @@
>      }
>      print "cpanm @cpanm_args \".\"\n" if !$silent;
>      my $rv = system('cpanm', @cpanm_args, '.');

add if ($rv != 0) { here

@@ +92,5 @@
>      my $rv = system('cpanm', @cpanm_args, '.');
> +    my $found_cpanm = 0;
> +    foreach my $path (split(/:/, $ENV{PATH})) {
> +	if (-x "$path/cpanm") {
> +		warn "cpanm installed\n";

remove this (debbung?) warning, it is confusing.
Also note this section is indented too much.
Use four spaces for every level of { } block.

@@ +98,5 @@
> +		last;
> +	}
> +    }
> +    if (!$found_cpanm) {
> +	warn "Please install cpanm: sudo apt-get install cpanminus\n";

suggestion: "you must install cpanminus (also known as cpanm) to use the --cpanm option\n"

@@ +105,1 @@
>      exit 1 if $rv != 0;

replace this line with }

Comment 3

[Anamika_07]

Attachment: Changes made

Comment 4

[Devika Sugathan]

Hello,
I'm an absolute beginner and would like to work on this.