1345977 - PTestSyncHangChild.h:134:11: error: private field 'mState' is not used

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

In a build with --enable-ipdl-tests and --enable-warnings-as-errors, the compiler complains about PTestSyncHangChild and PTestSyncHangParent each having a private unused field |State mState|. Bug 1342580 removed a useless accessor method, which I think stopped this warning from happening before. I assume this class hits the error and others don't because it is such a minimal class that it doesn't general any code that sends a message. I guess I can just add a dummy message.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1345977 - Add unused message to PTestSyncHang to prevent compiler warning.

Adding this unused message prevents a compiler warning
about the private field mState being unused.

Also, get rid of some trailing whitespace.

Review commit: https://reviewboard.mozilla.org/r/119282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119282/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8846183 [details]
Bug 1345977 - Add unused message to PTestSyncHang to prevent compiler warning.

https://reviewboard.mozilla.org/r/119282/#review121654

::: ipc/ipdl/test/cxx/PTestSyncHang.ipdl:13
(Diff revision 1)
>  child:
> +    // Add this unused message so we don't get compiler errors
> +    // complaining that mState is an unused private field.
> +    async UnusedMessage();
> +
>      async __delete__();

Can you remove __delete__ as well? I don't think it makes any sense in a top-level protocol.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8846183 [details]
Bug 1345977 - Add unused message to PTestSyncHang to prevent compiler warning.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119282/diff/1-2/

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Bill McCloskey (:billm) from comment #2)
> Can you remove __delete__ as well? I don't think it makes any sense in a
> top-level protocol.

Done. I also filed bug 1346911 to make that an error.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55359c6c4724
Add unused message to PTestSyncHang to prevent compiler warning. r=billm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/55359c6c4724