Stop doing special cancelation behavior for onmouseover and non-global-ErrorEvent onerror

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

2 years ago
Created attachment 8845628 [details] [diff] [review]
Change event handler invocation to only do the "true return cancels" for onerror handlers handed ErrorEvents, and only on globals

See https://github.com/whatwg/html/issues/2296 and
https://github.com/whatwg/html/issues/423 for details on what various browsers
do and whatnot.

MozReview-Commit-ID: DytkZreHudx
Attachment #8845628 - Flags: review?(bugs)
(Assignee)

Updated

2 years ago
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

Comment 2

2 years ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83b01c14f1f3
Change event handler invocation to only do the "true return cancels" for onerror handlers handed ErrorEvents, and only on globals.  r=smaug

Comment 3

2 years ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92fcd93e1d50
followup.  Update some tests for the new event behavior.

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/83b01c14f1f3
https://hg.mozilla.org/mozilla-central/rev/92fcd93e1d50
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.