1345997 - Add a check for the inspector toolbox when checking if the grid inspector or box model is visible

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

A coding exception was thrown and uncaught in a Task.

Full message: TypeError: this.inspector.toolbox is null
Full stack: isPanelVisible@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/boxmodel/box-model.js:81:5
updateBoxModel/lastRequest<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/boxmodel/box-model.js:140:13
_run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
spawn@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:161:12
updateBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/boxmodel/box-model.js:139:23
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:1304:7
onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:952:7
send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:570:13
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
DevToolsUtils.executeSoon*exports.executeSoon@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/DevToolsUtils.js:42:19
send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:563:9
send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/main.js:1491:5
receiveMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:761:7

*************************
console.error:
  Message: TypeError: this.inspector.toolbox is null
  Stack:
    isPanelVisible@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/boxmodel/box-model.js:81:5
updateBoxModel/lastRequest<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/boxmodel/box-model.js:140:13
_run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
spawn@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:161:12
updateBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/boxmodel/box-model.js:139:23
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:1304:7
onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/client/main.js:952:7
send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:570:13
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
DevToolsUtils.executeSoon*exports.executeSoon@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/DevToolsUtils.js:42:19
send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:563:9
send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/main.js:1491:5
receiveMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:761:7

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1345997 - Add a check for the inspector toolbox when checking if the grid inspector or box model is visible.

Review commit: https://reviewboard.mozilla.org/r/118790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118790/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8845652 [details]
Bug 1345997 - Add a check for the inspector toolbox when checking if the grid inspector or box model is visible.

https://reviewboard.mozilla.org/r/118790/#review120724

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/560eb8e7d89f
Add a check for the inspector toolbox when checking if the grid inspector or box model is visible. r=jdescottes

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/560eb8e7d89f