Closed Bug 1346067 Opened 7 years ago Closed 7 years ago

Sync test262 March edition

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: shu, Unassigned)

Details

Attachments

(3 files)

      No description provided.
Attached patch New tests.Splinter Review
Attachment #8845719 - Flags: review?(andrebargull)
Attachment #8845720 - Flags: review?(andrebargull)
Attachment #8845721 - Flags: review?(andrebargull)
Attachment #8845719 - Flags: review?(andrebargull) → review+
Comment on attachment 8845720 [details] [diff] [review]
New tests.

Review of attachment 8845720 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8845720 - Flags: review?(andrebargull) → review+
Comment on attachment 8845721 [details] [diff] [review]
Update skip list.

Review of attachment 8845721 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: js/src/tests/jstests.list
@@ +866,5 @@
>  
>  
>  ####################################################
>  # Tests disabled due to invalid test expectations  #
>  ####################################################

This section needs to be updated, too. IIRC all tests should now work correctly in SpiderMonkey, but please double-check.
Attachment #8845721 - Flags: review?(andrebargull) → review+
(In reply to André Bargull from comment #5)
> ::: js/src/tests/jstests.list
> @@ +866,5 @@
> >  
> >  
> >  ####################################################
> >  # Tests disabled due to invalid test expectations  #
> >  ####################################################
> 
> This section needs to be updated, too. IIRC all tests should now work
> correctly in SpiderMonkey, but please double-check.

Okay, I've just verified this locally, you can remove all test exclusions from this section.
We probably need to add a "skip-if" for the Atomics and SharedArrayBuffer tests, so it doesn't cause issues when the test262 changes are uplifted, but Atomics and SharedArrayBuffer are still disabled on future beta/release.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: