Sync test262 March edition

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: shu, Unassigned)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

9 months ago
Created attachment 8845719 [details] [diff] [review]
$ renamed to $262 upstream.
(Reporter)

Comment 2

9 months ago
Created attachment 8845720 [details] [diff] [review]
New tests.
(Reporter)

Comment 3

9 months ago
Created attachment 8845721 [details] [diff] [review]
Update skip list.
(Reporter)

Updated

9 months ago
Attachment #8845719 - Flags: review?(andrebargull)
(Reporter)

Updated

9 months ago
Attachment #8845720 - Flags: review?(andrebargull)
(Reporter)

Updated

9 months ago
Attachment #8845721 - Flags: review?(andrebargull)

Updated

9 months ago
Attachment #8845719 - Flags: review?(andrebargull) → review+
Comment on attachment 8845720 [details] [diff] [review]
New tests.

Review of attachment 8845720 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8845720 - Flags: review?(andrebargull) → review+
Comment on attachment 8845721 [details] [diff] [review]
Update skip list.

Review of attachment 8845721 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: js/src/tests/jstests.list
@@ +866,5 @@
>  
>  
>  ####################################################
>  # Tests disabled due to invalid test expectations  #
>  ####################################################

This section needs to be updated, too. IIRC all tests should now work correctly in SpiderMonkey, but please double-check.
Attachment #8845721 - Flags: review?(andrebargull) → review+
(In reply to André Bargull from comment #5)
> ::: js/src/tests/jstests.list
> @@ +866,5 @@
> >  
> >  
> >  ####################################################
> >  # Tests disabled due to invalid test expectations  #
> >  ####################################################
> 
> This section needs to be updated, too. IIRC all tests should now work
> correctly in SpiderMonkey, but please double-check.

Okay, I've just verified this locally, you can remove all test exclusions from this section.
We probably need to add a "skip-if" for the Atomics and SharedArrayBuffer tests, so it doesn't cause issues when the test262 changes are uplifted, but Atomics and SharedArrayBuffer are still disabled on future beta/release.

Comment 8

9 months ago
Pushed by shu@rfrn.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d0d30dd800a
$ renamed to $262 upstream. (r=anba)
https://hg.mozilla.org/integration/mozilla-inbound/rev/00ecf638b381
Sync test262. (rs=anba)
https://hg.mozilla.org/integration/mozilla-inbound/rev/fafa0183bec1
Update skip list. (r=anba)

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d0d30dd800a
https://hg.mozilla.org/mozilla-central/rev/00ecf638b381
https://hg.mozilla.org/mozilla-central/rev/fafa0183bec1
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.