[test262][ecma402] Wrong DateTimeFormat.prototype.format.length

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript: Internationalization API
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: gandalf, Assigned: anba)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
test262 errors with:

## test262/intl402/DateTimeFormat/prototype/format/12.3.2_1_a_L15.js: rc = 3, run time = 0.035526
uncaught exception: Test262Error: Function's length property doesn't have specified value; expected 1, got 0.
(Assignee)

Comment 1

7 months ago
Previous discussion about this spec change: https://github.com/tc39/ecma402/issues/76
(Assignee)

Comment 2

7 months ago
I've filed https://github.com/tc39/ecma402/issues/133 because I think DateTimeFormat.prototype.formatToParts's length should be changed to 1, too.
(Assignee)

Updated

7 months ago
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
(Assignee)

Comment 3

7 months ago
Created attachment 8855278 [details] [diff] [review]
bug1346079.patch

Changes function "length" property of Intl.DateTimeFormat.prototype.format and Intl.DateTimeFormat.prototype.formatToParts from 0 to 1 per the current Intl spec.

Drive-by change: Updates step references in collatorCompareToBind, Intl_Collator_compare_get, numberFormatFormatToBind, and dateTimeFormatFormatToBind to match the latest spec.
Attachment #8855278 - Flags: review?(gandalf)
(Reporter)

Comment 4

7 months ago
Comment on attachment 8855278 [details] [diff] [review]
bug1346079.patch

lgtm!
Attachment #8855278 - Flags: review?(gandalf) → review+
(Assignee)

Comment 5

6 months ago
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f573b326c4edde1d35189ac4c76e7493be39a4ca
Keywords: checkin-needed

Comment 6

6 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df176b9cd582
Update length of function returned from DateTimeFormat.prototype.format to match latest spec. r=gandalf
Keywords: checkin-needed

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df176b9cd582
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.