Closed
Bug 1346080
Opened 8 years ago
Closed 7 years ago
[test262][ecma402] Tainting of "type" works in PluralRules.prototype.select
Categories
(Core :: JavaScript: Internationalization API, enhancement)
Core
JavaScript: Internationalization API
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: anba)
Details
Attachments
(1 file)
5.06 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
test262 errors with:
## test262/intl402/PluralRules/prototype/select/tainting.js: rc = 3, run time = 0.058382
uncaught exception: Test262Error: Client code can adversely affect behavior: setter for type.
Assignee | ||
Comment 1•8 years ago
|
||
The setter is called from the test harness itself (http://searchfox.org/mozilla-central/rev/7cb75d87753de9103253e34bc85592e26378f506/js/src/tests/shell.js#458). :-/
Assignee: nobody → andrebargull
Assignee | ||
Comment 2•7 years ago
|
||
I guess the easiest way to fix this issue, is to make TestCase.prototype no longer inherit from Object.prototype. And I've also changed the TestCase constructor to simply call the existing ArrayPush helper instead of calling ObjectDefineProperty manually.
Attachment #8924600 -
Flags: review?(jwalden+bmo)
Comment 3•7 years ago
|
||
Comment on attachment 8924600 [details] [diff] [review]
bug1346080.patch
Review of attachment 8924600 [details] [diff] [review]:
-----------------------------------------------------------------
TestCase remains abominable over-engineering, but this is exactly why I started all this IIFE business so long ago. Great to see it coming to useful fruition, and so easily, too!
Attachment #8924600 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c5fbdd2af8e45c5fafd8af65aa05d23f566f3c7
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/908c36075a85
Make jstests TestCase object resilient against Object.prototype changes. r=Waldo
Keywords: checkin-needed
![]() |
||
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•