Closed
Bug 1346084
Opened 7 years ago
Closed 7 years ago
Expose mozIntl.getLocaleInfo to ChromeOrXBL
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
Attachments
(1 file, 2 obsolete files)
|
6.52 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
To know the direction (rtl or ltr) of the locale.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8846934 -
Flags: review?(bugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8846934 [details] [diff] [review] patch, v1. Perhaps add a test when locales is empty array or something.
Attachment #8846934 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
added a test when locales is an empty array, carrying r+.
Attachment #8846934 -
Attachment is obsolete: true
Attachment #8847387 -
Flags: review+
|
||
Comment 4•7 years ago
|
||
The test that you added will work only if the test infra is run on en-US Firefox. It would be better to de-hardcode "en-US" and "ltr" and instead take it from Service.locale.getAppLocaleAsBCP47 and mozIntl.getLocaleInfo(locale).rtl for that locale.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Use mozILocaleService.getAppLocaleAsBCP47() to get default locale in tests, see comment 4.
Attachment #8847387 -
Attachment is obsolete: true
Attachment #8847405 -
Flags: review+
|
|
Assignee | |
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=56ee986579eba50e5f87a073886446c9a20de52c&group_state=expanded
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e19d4c92575 Expose mozIntl.getLocaleInfo to ChromeOrXBL. r=smaug
Keywords: checkin-needed
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9e19d4c92575
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•