Remove redundant AppConstants.jsm import from browser.js

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: fedepad, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

I would be interested in working on this. Mainly just to get familiar with the processes involved. Though I have no idea where to start or how to create and submit a patch for this.
Reporter

Comment 2

2 years ago
(In reply to Wickie Lee [:Robocrypt] from comment #1)
> I would be interested in working on this. Mainly just to get familiar with
> the processes involved. Though I have no idea where to start or how to
> create and submit a patch for this.

Have you built Firefox yet? See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to Wickie Lee [:Robocrypt] from comment #1)
> > I would be interested in working on this. Mainly just to get familiar with
> > the processes involved. Though I have no idea where to start or how to
> > create and submit a patch for this.
> 
> Have you built Firefox yet? See
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Yep, I have already built Firefox. I guess my confusion comes from the process of creating patch, the review process (MozReview vs Bugzilla), such as how to perform either or which one do I use. And then actually getting the patch into Firefox.
Reporter

Comment 4

2 years ago
Either bugzilla or mozreview are fine. You can get patches landed using the checkin-needed keywords in bugzilla, but let's not worry about that for now.
Assignee

Comment 5

2 years ago
Since it's been 6 days since last update and this bug has not been assigned I'm pushing something for review.

Thanks.
Comment hidden (mozreview-request)
Reporter

Comment 7

2 years ago
mozreview-review
Comment on attachment 8848887 [details]
Bug 1346188 - Remove redundant AppConstants.jsm import from browser.js;

https://reviewboard.mozilla.org/r/121762/#review124074

Thanks!
Attachment #8848887 - Flags: review?(dao+bmo) → review+
Reporter

Updated

2 years ago
Assignee: nobody → federico_padua

Comment 8

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6463366885d
Remove redundant AppConstants.jsm import from browser.js; r=dao
Assignee

Comment 9

2 years ago
mozreview-review-reply
Comment on attachment 8848887 [details]
Bug 1346188 - Remove redundant AppConstants.jsm import from browser.js;

https://reviewboard.mozilla.org/r/121762/#review124074

You're welcome! Thank to you!

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a6463366885d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.