Closed Bug 1346189 Opened 7 years ago Closed 4 years ago

Inline AddSlot in Ion based on BaselineInspector

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX
Project Flags:
Performance Impact low

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf) 

Ion always requires an IC for this but it shows up a lot. We should inline the monomorphic case with input from BaselineInspector.
Priority: -- → P2
Whiteboard: [qf:p1]
Whiteboard: [qf:p1] → [qf:p2]
Keywords: perf
Whiteboard: [qf:p2] → [qf:p1]
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Whiteboard: [qf:p1] → [qf:i60][qf:p1]
Whiteboard: [qf:i60][qf:p1] → [qf:f60][qf:p1]
Whiteboard: [qf:f60][qf:p1] → [qf:f61][qf:p1]
I'm not working on this now. I prototyped this last year and IIRC it was less of a win than expected - probably because adding a new slot is relatively slow anyway so the IC overhead matters less.
Assignee: jdemooij → nobody
Status: ASSIGNED → NEW
Was it still a reasonable win?  Do you think this should land or should we just forget about this?
Flags: needinfo?(jdemooij)
(In reply to Kannan Vijayan [:djvj] from comment #2)
> Was it still a reasonable win?  Do you think this should land or should we
> just forget about this?

I don't remember the exact numbers :/ I think we should keep this open but low priority for now.

Also note that when we remove unboxed objects, this will become a bit simpler (because the AddSlot code also supports expando properties on unboxed objects).
Flags: needinfo?(jdemooij)
Priority: P2 → P3
Whiteboard: [qf:f61][qf:p1] → [qf:f64][qf:p1]
Whiteboard: [qf:f64][qf:p1] → [qf:p1:f64]
Whiteboard: [qf:p1:f64] → [qf:p1:f67]
Whiteboard: [qf:p1:f67] → [qf:p3]

We don't implement this for Ion anymore, but Warp can does this since bug 1658990 / bug 1659424.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Performance Impact: --- → P3
Whiteboard: [qf:p3]
You need to log in before you can comment on or make changes to this bug.