1346212 - Cannot revert a rule change: https://aus4-admin.mozilla.org/api/rules/undefined/revisions

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

STEPS TO REPRODUCE
1. View the history of a rule.
2. Revert to the one-before-last revision

RESULTS
The UI shows the following error:
> A resource was requested that can't be found (POST /api/rules/undefined/revisions)

The state of rule remained the same. The network panel shows that the front end requested:
> https://aus4-admin.mozilla.org/api/rules/undefined/revisions

REPRO FREQUENCY: 3/3

ENVIRONMENT
First noticed on the current production env. Then, repro'd against the latest master, revision 8f8057168b0ab13177468cac93b85af4cfcb2472

Comment 1

[[e-mail] (:bhearsum)]

Looks like this happens for revisions further back than N-1 too. I'm guessing the "Revert" button is completely busted. Probably something wrong in one of:
https://github.com/mozilla/balrog/blob/8f8057168b0ab13177468cac93b85af4cfcb2472/ui/app/js/controllers/rules_controller.js
https://github.com/mozilla/balrog/blob/8f8057168b0ab13177468cac93b85af4cfcb2472/ui/app/templates/rules.html
https://github.com/mozilla/balrog/blob/8f8057168b0ab13177468cac93b85af4cfcb2472/ui/app/js/controllers/rule_revert_controller.js

Comment 2

[Harkishen H [:harikishenh]]

I would like to work on this.

Comment 3

[[e-mail] (:bhearsum)]

It's all yours! Do you know how to get started?

Comment 4

[Harkishen H [:harikishenh]]

Actually i'm new to balrog , new to opensource in fact. I also want your help on https://bugzilla.mozilla.org/show_bug.cgi?id=1363058

Comment 5

[Harkishen H [:harikishenh]]

I believe this should fix this: https://github.com/mozilla/balrog/pull/324.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/a223b6eea5afb694ad817a2a1a76291b6917eab0
bug 1346212: Cannot revert a rule change (#324). r=bhearsum

Comment 7

[[e-mail] (:bhearsum)]

In production. Thanks for fixing this Harkishen!