Closed Bug 1346272 Opened 6 years ago Closed 6 years ago

Duplicated string charts.totalSize in netmonitor.properties

Categories

(DevTools :: Netmonitor, enhancement, P1)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

Bug 1346272 - Remove duplicate string charts.totalSize from netmonitor.properties,
59 bytes, text/x-review-board-request
Honza
: review+
Details 
charts.totalSize is declared twice, at line 238 and 254

https://hg.mozilla.org/releases/mozilla-aurora/file/default/devtools/client/locales/en-US/netmonitor.properties#l238

We discovered it because a localization tool is chocking on the file, so we'll also need to uplift the fix to m-a
Assignee: nobody → francesco.lodolo
Comment on attachment 8845967 [details]
Bug 1346272 - Remove duplicate string charts.totalSize from netmonitor.properties,

https://reviewboard.mozilla.org/r/119054/#review121464

Thanks for the patch!

Honza
Attachment #8845967 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f64fabc72583
Remove duplicate string charts.totalSize from netmonitor.properties,r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f64fabc72583
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.