Closed
Bug 1346272
Opened 5 years ago
Closed 5 years ago
Duplicated string charts.totalSize in netmonitor.properties
Categories
(DevTools :: Netmonitor, enhancement, P1)
DevTools
Netmonitor
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
charts.totalSize is declared twice, at line 238 and 254 https://hg.mozilla.org/releases/mozilla-aurora/file/default/devtools/client/locales/en-US/netmonitor.properties#l238 We discovered it because a localization tool is chocking on the file, so we'll also need to uplift the fix to m-a
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → francesco.lodolo
Comment 2•5 years ago
|
||
mozreview-review |
Comment on attachment 8845967 [details] Bug 1346272 - Remove duplicate string charts.totalSize from netmonitor.properties, https://reviewboard.mozilla.org/r/119054/#review121464 Thanks for the patch! Honza
Attachment #8845967 -
Flags: review?(odvarko) → review+
Updated•5 years ago
|
Priority: -- → P1
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f64fabc72583 Remove duplicate string charts.totalSize from netmonitor.properties,r=Honza
Keywords: checkin-needed
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f64fabc72583
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•