1346284 - Update Android NDK installed by |mach bootstrap| to NDK r11c

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

We're seeing problems building with r11b, and the builders have moved on to Android NDK r11c.  We should update the bootstrap and the Wiki page.

Comment 1

[Nick Alexander :nalexander [he/him]]

This is a good mentored ticket; it might even be a good first bug.

I think what you need to do is:
- replace r11b with r11c throughout the results of https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=path%3Amozboot%20%22r11b%22
- test that it works locally by running |./mach bootstrap| and verifying you get r11c somewhere in ~/.mozbuild.
- update https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build#Required_Android_SDK_and_NDK_versions

Comment 2

[Nick Alexander :nalexander [he/him]]

Suman: you got bitten by this -- are you interested in fixing it?  If you know a little Python, you should be able to do it.

Comment 3

[suman gupta]

Yes sure. I will be glad to do it. This is going to be only my second bug. So will need your guidance too.

Comment 4

[suman gupta]

Yes sure. I will be glad to do it. This is going to be only my second bug. So will need your guidance too.

Comment 5

[suman gupta]

Nick, I have made the changes locally, tested it as you suggested and it is working as per expectation. But,can you hint me on how to start with updating the wiki page part?

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to suman gupta from comment #5)
> Nick, I have made the changes locally, tested it as you suggested and it is
> working as per expectation. But,can you hint me on how to start with
> updating the wiki page part?

Can you post your patch for me to review?  https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch should guide you through.

To update MDN, go to https://developer.mozilla.org/en-US/docs/MDN/Contribute/Howto and read the "How to create an account" and "How to [create and] edit pages" guides.  Then go to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build#Required_Android_SDK_and_NDK_versions, choose to Edit in the top right hand corner (assuming your locale is left-to-right!), and then update the r11b to r11c in the relevant section.

Thanks for digging in!

Comment 7

[suman gupta]

Attachment: Bug 1346284 Updated ndk r11c to be installed by mach bootstrap;

Review commit: https://reviewboard.mozilla.org/r/119746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119746/

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8846742 [details]
Bug 1346284 Updated ndk r11c to be installed by mach bootstrap;

https://reviewboard.mozilla.org/r/119746/#review121618

Looks good to me!  I'll mark this as checkin-needed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1bb6f282422
Updated ndk r11c to be installed by mach bootstrap; r=nalexander

Comment 10

[suman gupta]

I will also create an MDN account and update the MDN as soon as I can. Thanks!

Comment 11

[suman gupta]

I have made the change in MDN and published it.

Comment 12

[Nick Alexander :nalexander [he/him]]

(In reply to suman gupta from comment #11)
> I have made the change in MDN and published it.

Thanks, Suman!  Welcome aboard!

Comment 13

[suman gupta]

Thanks Nick for guiding!

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1bb6f282422