Closed Bug 1346291 Opened 3 years ago Closed 2 years ago

Update libyuv to 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12

Categories

(Core :: Graphics, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: tjr, Assigned: jesup)

References

Details

(Whiteboard: [gfx-noted] [third-party-lib-audit])

Attachments

(3 files, 1 obsolete file)

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 0741a3d70400dc96e59726674b0acf3bca02d710.

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Priority: -- → P3
Whiteboard: [gfx-noted]
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 2adb84e39e360723d19c68f315d99e3e0f88318c. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 0741a3d70400dc96e59726674b0acf3bca02d710 → Update libyuv to 2adb84e39e360723d19c68f315d99e3e0f88318c
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 8cab2e31d76246263206318f3568d452e7f3ff3e. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 2adb84e39e360723d19c68f315d99e3e0f88318c → Update libyuv to 8cab2e31d76246263206318f3568d452e7f3ff3e
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is fc02cc3806a394a6b887979ba74aa49955f3199b. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 8cab2e31d76246263206318f3568d452e7f3ff3e → Update libyuv to fc02cc3806a394a6b887979ba74aa49955f3199b
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 3b583396bf138334e90e06ad901f73589a929474. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to fc02cc3806a394a6b887979ba74aa49955f3199b → Update libyuv to 3b583396bf138334e90e06ad901f73589a929474
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 945ea1b7463004581502ebbcfc5a0b2f54ff6867. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 3b583396bf138334e90e06ad901f73589a929474 → Update libyuv to 945ea1b7463004581502ebbcfc5a0b2f54ff6867
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 8edd2286fdf9df2b9da806bda7ed262492f95921. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 945ea1b7463004581502ebbcfc5a0b2f54ff6867 → Update libyuv to 8edd2286fdf9df2b9da806bda7ed262492f95921
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is 7bffe5e1c54bc22daebd57003735e61693719ac6. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 8edd2286fdf9df2b9da806bda7ed262492f95921 → Update libyuv to 7bffe5e1c54bc22daebd57003735e61693719ac6
Whiteboard: [gfx-noted] → [gfx-noted] [third-party-lib-audit]
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

libyuv is currently at version 054ec37f8e31e6131c8f19eb74395d29009d6604 in mozilla-central, and the latest version of the library released is d8136924bd0bef0cf39ef379d03196950ce58418. 

I fetched the latest version of the library from https://chromium.googlesource.com/chromium/src/+/master/DEPS.

(Technically, this 'latest commit' is not a release, but Chromium has rolled their dependency of libyuv.)
Summary: Update libyuv to 7bffe5e1c54bc22daebd57003735e61693719ac6 → Update libyuv to d8136924bd0bef0cf39ef379d03196950ce58418
Summary: Update libyuv to d8136924bd0bef0cf39ef379d03196950ce58418 → Update libyuv to 56022ef77fab3ce5a7c8ee44bd095c22a94bff5b
Summary: Update libyuv to 56022ef77fab3ce5a7c8ee44bd095c22a94bff5b → Update libyuv to 27036e33e86c9ce3b5087d55c18bf04964343c60
Summary: Update libyuv to 27036e33e86c9ce3b5087d55c18bf04964343c60 → Update libyuv to 5b1af9a33545895ea12c52bf007f17914de19173
Summary: Update libyuv to 5b1af9a33545895ea12c52bf007f17914de19173 → Update libyuv to 8fa02df3c0591754958a50cc2896aafae319f3bc
Summary: Update libyuv to 8fa02df3c0591754958a50cc2896aafae319f3bc → Update libyuv to 12c904a97c81c3ef4cab0fc8fb1f0485b4ec4e8c
Summary: Update libyuv to 12c904a97c81c3ef4cab0fc8fb1f0485b4ec4e8c → Update libyuv to d94a4867bf8be91e4c0fa8b7a4133ba060fe524f
Summary: Update libyuv to d94a4867bf8be91e4c0fa8b7a4133ba060fe524f → Update libyuv to c67db6053495a2744511a43ba7b6ba3fa49b26a5
Summary: Update libyuv to c67db6053495a2744511a43ba7b6ba3fa49b26a5 → Update libyuv to 263243aadc3c30d548ffc36e6fdb0cc987511cc6
Summary: Update libyuv to 263243aadc3c30d548ffc36e6fdb0cc987511cc6 → Update libyuv to 50f9e618fa4bcb0561622fd709bee5da922b0fd4
See Also: → 1429617
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
A new version has rolled: 09db0c4ce2008008f73b247f1a5b64cfbb29b72e
Summary: Update libyuv to 50f9e618fa4bcb0561622fd709bee5da922b0fd4 → Update libyuv to 09db0c4ce2008008f73b247f1a5b64cfbb29b72e
Summary: Update libyuv to 09db0c4ce2008008f73b247f1a5b64cfbb29b72e → Update libyuv to 92e22cf5b66173d5d5056751ca62bc2254e4ff86
Summary: Update libyuv to 92e22cf5b66173d5d5056751ca62bc2254e4ff86 → Update libyuv to ffec313dbe58c6b97d4943387bda618dccbe4591
Summary: Update libyuv to ffec313dbe58c6b97d4943387bda618dccbe4591 → Update libyuv to b792e0dbc152dbeea6f4a5ba59dccd05c32eb3c2
Summary: Update libyuv to b792e0dbc152dbeea6f4a5ba59dccd05c32eb3c2 → Update libyuv to 439fc3ce3d7b4bc0a584617ebc2160c083006d28
Summary: Update libyuv to 439fc3ce3d7b4bc0a584617ebc2160c083006d28 → Update libyuv to 66305588755486b27380b58c04aa8c1cf4541af3
Summary: Update libyuv to 66305588755486b27380b58c04aa8c1cf4541af3 → Update libyuv to 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12
Patch to do the update will be right behind this; pushing Try.  Update script has --no-patches option to make it easier to update patches when importing
Attachment #8974512 - Flags: review?(tom)
just looking for a rubber-stamp (and perhaps looking at the changes upstream for this version); not a code-review of all the changes
Attachment #8974517 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8974512 [details] [diff] [review]
Update libyuv update script and update patches for upstream 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12

I'll rubber stamp.
Attachment #8974512 - Flags: review?(tom) → review+
Oh actually...

The latest version of libyuv in Chromium is a9626b9daf62a9b260737e9c2de821ad087b19a1 - from https://chromium.googlesource.com/chromium/src/+/master/DEPS#765


I confess I stopped updating this bug because they were rolling new libyuv versions every week and nothing had happened here for months.  So if the choice of 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12 was made because of the bug title, then really we should use a9626b9daf62a9b260737e9c2de821ad087b19a1.

libyuv updates really regularly. I have been planning a tool for automatic updates, and I think libyuv would be a good candidate for testing it after it reaches its MVP....
Attachment #8974538 - Flags: review?(jib) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=44408b701cb56191ceba74fd7e4183cda49239dc&selectedJob=177749224
Looks green; nothing that seems to point back to libyuv.  (A few tests are still running)
Attachment #8974517 - Flags: review?(sotaro.ikeda.g) → review+
Comment on attachment 8974538 [details] [diff] [review]
update code that accidentally assumed libyuv would define things like int32

Review of attachment 8974538 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8974538 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8941676 - Attachment is obsolete: true
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/738b40299efa
Update libyuv update script and update patches for upstream 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12 r=tritter
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f2b06896dfd
Update libyuv to upstream 98a0a157dcf5dee0882b2dfcc9578ab1f44afb12 rs=jib,sotaro
https://hg.mozilla.org/integration/mozilla-inbound/rev/1feb2371c435
update code that accidentally assumed libyuv would define things like int32 r=sotaro,jib
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef3bf9d981a
remove accidentally committed diff file rs=jesup NPOTB
You need to log in before you can comment on or make changes to this bug.