Uncomment out ThreeWayMerger.swift code when Swift Optimizations work on Xcode 8.3

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

(Whiteboard: [MobileCore])

(Assignee)

Description

a year ago
To work around the swift optimization issues with ThreeWayMerger.swift, we had to comment out some code and exclude the source file from the Sync target in order for it to compile. If this change lands on master we'll need to uncomment out the code and add back in the source file so we can get bidirectional bookmark syncing working.
tracking-fxios: 8.0+ → ?
(Assignee)

Updated

a year ago
tracking-fxios: ? → 8.0+
Priority: -- → P1
(Assignee)

Updated

a year ago
Iteration: --- → 1.19
(Assignee)

Updated

a year ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
(Assignee)

Comment 1

a year ago
The commenting out patch never landed on master and only lives on the v7.x. Marking as resolved.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.