59 bytes, text/x-review-board-request
At http://ftp.mozilla.org/pub/firefox/nightly/2017/02/2017-02-01-11-00-31-mozilla-central/ file size is 10M At http://ftp.mozilla.org/pub/firefox/nightly/2017/02/2017-02-02-11-01-08-mozilla-central/ file size is 71M Looks like binary is not `strip`ed. Is it regression from bug 1335309?
This is a major issue for AMO websites as they use jsshell to validate add-on code. We are currently stuck at 52.0.
Assignee: nobody → mh+mozilla
Comment on attachment 8847007 [details] Bug 1346381 - Strip executables in the jsshell package. https://reviewboard.mozilla.org/r/120052/#review122182
Attachment #8847007 - Flags: review?(mshal) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d48202815d98 Strip executables in the jsshell package. r=mshal
Comment on attachment 8847007 [details] Bug 1346381 - Strip executables in the jsshell package. Approval Request Comment [Feature/Bug causing the regression]: Regression from bug 1335309 [User impact if declined]: jsshell package too large [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: It has been verified on landing. [Needs manual test from QE? If yes, steps to reproduce]: Check the size of the jsshell.zip file, before and after. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No [Why is the change risky/not risky?]: There is no real logic change, just a change in how existing code is called such that it matches what was happening before bug 1335309. [String changes made/needed]: N/A
Attachment #8847007 - Flags: approval-mozilla-aurora?
Comment on attachment 8847007 [details] Bug 1346381 - Strip executables in the jsshell package. fix jsshell not being stripped, aurora54+
Attachment #8847007 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.