1346381 - jsshell-linux-x86_64.zip file size grew 7x times

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Yury Delendik (:yury)]

At http://ftp.mozilla.org/pub/firefox/nightly/2017/02/2017-02-01-11-00-31-mozilla-central/ file size is 10M
At http://ftp.mozilla.org/pub/firefox/nightly/2017/02/2017-02-02-11-01-08-mozilla-central/ file size is 71M

Looks like binary is not `strip`ed. Is it regression from bug 1335309?

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

This is a major issue for AMO websites as they use jsshell to validate add-on code. We are currently stuck at 52.0.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1346381 - Strip executables in the jsshell package.

In bug 1335309, FileFinder was made to default to not find executables,
and zip.py was made to use the default instead. Which made sense for
most uses of zip.py, except for the jsshell package.

So we add a flag to make zip.py able to strip executable (which happens
when the FileFinder is made to find them), and use that flag for the
jsshell package only.

Review commit: https://reviewboard.mozilla.org/r/120052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120052/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120052/diff/1-2/

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

https://reviewboard.mozilla.org/r/120052/#review122182

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d48202815d98
Strip executables in the jsshell package. r=mshal

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1335309
[User impact if declined]: jsshell package too large
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It has been verified on landing.
[Needs manual test from QE? If yes, steps to reproduce]: Check the size of the jsshell.zip file, before and after.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: There is no real logic change, just a change in how existing code is called such that it matches what was happening before bug 1335309.
[String changes made/needed]: N/A

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

fix jsshell not being stripped, aurora54+

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d48202815d98

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e00635bc10f0