jsshell-linux-x86_64.zip file size grew 7x times

RESOLVED FIXED in Firefox 54

Status

defect
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: yury, Assigned: glandium)

Tracking

({regression})

Trunk
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed, firefox55 fixed)

Details

Attachments

(1 attachment)

Keywords: regression
Flags: needinfo?(mh+mozilla)
This is a major issue for AMO websites as they use jsshell to validate add-on code. We are currently stuck at 52.0.
Assignee: nobody → mh+mozilla
Flags: needinfo?(mh+mozilla)
Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

https://reviewboard.mozilla.org/r/120052/#review122182
Attachment #8847007 - Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/d48202815d98
Strip executables in the jsshell package. r=mshal
Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1335309
[User impact if declined]: jsshell package too large
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It has been verified on landing.
[Needs manual test from QE? If yes, steps to reproduce]: Check the size of the jsshell.zip file, before and after.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: There is no real logic change, just a change in how existing code is called such that it matches what was happening before bug 1335309.
[String changes made/needed]: N/A
Attachment #8847007 - Flags: approval-mozilla-aurora?
Comment on attachment 8847007 [details]
Bug 1346381 - Strip executables in the jsshell package.

fix jsshell not being stripped, aurora54+
Attachment #8847007 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/d48202815d98
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.