Update context menu for new Activity Stream Panel

RESOLVED FIXED

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: farhan, Assigned: farhan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

(Whiteboard: [mobileAS])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
bmunar
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Migrating AS into a UICollectionView has broken the Context menu. Make sure the context menu works correctly. 

A few other things have also changed that should be fixed with this PR. 
There are now UIImageViewExtensions to set Favicons that provide correct background colors. So no need to pass the UIImage and UIColor from the HighlightCell/TopSiteCell to the context menu.
(Assignee)

Updated

2 years ago
Blocks: 1311405
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Farhan, I took a look at this and wasn't able to determine what the issue was with the context menu. Could you elaborate?
Assignee: jdarcangelo → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(fpatel)
Please remember to nominate.
tracking-fxios: --- → ?
(Assignee)

Comment 3

2 years ago
This is a preemptive bug for the changes that will occur when we migrate to UICollectionView. So you wont notice this on master. Yet!
Flags: needinfo?(fpatel)
(Assignee)

Updated

2 years ago
tracking-fxios: ? → 8.0+
(Assignee)

Comment 4

2 years ago
Created attachment 8853743 [details] [review]
Pull Request
Attachment #8853743 - Flags: review?(bmunar)
Attachment #8853743 - Flags: review?(bmunar) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → fpatel
Iteration: --- → 1.19
Priority: P2 → P1
(Assignee)

Comment 5

2 years ago
master https://github.com/mozilla-mobile/firefox-ios/commit/dda2e60cec612dd2e2e7ec1458ab4fba81fd3516
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.