Migrating AS into a UICollectionView has broken the Context menu. Make sure the context menu works correctly. A few other things have also changed that should be fixed with this PR. There are now UIImageViewExtensions to set Favicons that provide correct background colors. So no need to pass the UIImage and UIColor from the HighlightCell/TopSiteCell to the context menu.
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Farhan, I took a look at this and wasn't able to determine what the issue was with the context menu. Could you elaborate?
Assignee: jdarcangelo → nobody
Status: ASSIGNED → NEW
Please remember to nominate.
tracking-fxios: --- → ?
This is a preemptive bug for the changes that will occur when we migrate to UICollectionView. So you wont notice this on master. Yet!
Created attachment 8853743 [details] [review] Pull Request
Attachment #8853743 - Flags: review?(bmunar)
Assignee: nobody → fpatel
Iteration: --- → 1.19
Priority: P2 → P1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.