1346442 - regex_token_iterator doesn't link on ASAN builds

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kelsey Gilbert [:jgilbert]]

It looks like we're using libGCC 4.8.5 when we build with clang here.


> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `DoesRegexWork':
> /home/worker/workspace/build/src/dom/canvas/WebGLContextValidate.cpp:47: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator<2ul>(__gnu_cxx::__normal_iterator<char const*, std::string>, __gnu_cxx::__normal_iterator<char const*, std::string>, std::basic_regex<char, std::regex_traits<char> > const&, int const (&) [2ul], std::bitset<11ul>)'
> /home/worker/workspace/build/src/dom/canvas/WebGLContextValidate.cpp:48: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/dom/canvas/WebGLContextValidate.cpp:48: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator()'
> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `std::vector<std::string, std::allocator<std::string> >::vector<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, void>(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::allocator<std::string> const&)':
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:395: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:395: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `void std::vector<std::string, std::allocator<std::string> >::_M_initialize_dispatch<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > >(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::__false_type)':
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:1177: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:1177: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `void std::vector<std::string, std::allocator<std::string> >::_M_range_initialize<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > >(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::forward_iterator_tag)':
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:1200: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> ../../dom/canvas/Unified_cpp_dom_canvas2.o:/home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_vector.h:1200: more undefined references to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)' follow
> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `std::iterator_traits<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > >::difference_type std::distance<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > >(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >)':
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_iterator_base_funcs.h:80: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator!=(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_iterator_base_funcs.h:82: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator++()'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_iterator_base_funcs.h:80: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator!=(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `std::string* std::__uninitialized_copy_a<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::string*, std::string>(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::string*, std::allocator<std::string>&)':
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:258: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:258: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:117: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:117: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::regex_token_iterator(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> ../../dom/canvas/Unified_cpp_dom_canvas2.o: In function `std::string* std::__uninitialized_copy<false>::__uninit_copy<std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::string*>(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >, std::string*)':
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:74: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator!=(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:75: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator*()'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:74: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator++()'
> /home/worker/workspace/build/src/clang/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../include/c++/4.8.5/bits/stl_uninitialized.h:74: undefined reference to `std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> >::operator!=(std::regex_token_iterator<__gnu_cxx::__normal_iterator<char const*, std::string>, char, std::regex_traits<char> > const&)'
> clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)
> /home/worker/workspace/build/src/config/rules.mk:804: recipe for target 'libxul.so' failed
> gmake[5]: *** [libxul.so] Error 1

Comment 1

[Mike Hommey [:glandium]]

08:42 <glandium> ah, that's because clang has an embedded copy of libstdc++, coming from the old gcc
08:53 <glandium> jgilbert: Take the relevant build artifacts from 
                 https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=5e691d87bed93f740094604be686567b34a6f29d&filter-searchStr=clang, upload them to 
                 tooltool, and update the tooltool manifests

Comment 3

[Kelsey Gilbert [:jgilbert]]

Here's the treeherder link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=23df1a294c6e9b0dd6360c30995a56acbdf6f9e6&selectedJob=83129517

Comment 4

[Kelsey Gilbert [:jgilbert]]

Looks like we want this one:
https://queue.taskcluster.net/v1/task/Ro1bUCv4Svu2OWuQsOF_hA/runs/0/artifacts/public/clang.tar.xz

This appears to be clang 3.9.0 and libgcc 4.9.4.

I can't upload to tooltool myself though.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1346442 - Update linux64 asan builds to clang3.9+libgcc4.9.4 -

Review commit: https://reviewboard.mozilla.org/r/119312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119312/

Comment 6

[Aki Sasaki (not active)]

Uploaded to tooltool:
[
  {
    "size": 166261192,
    "visibility": "public",
    "digest": "52f3fc23f0f5c98050f8b0ac7c92a6752d067582a16f712a5a58074be98975d594f9e36249fc2be7f1cc2ca6d509c663faaf2bea66f949243cc1f41651638ba6",
    "algorithm": "sha512",
    "filename": "clang.tar.xz"
  }
]

Comment 7

[Kelsey Gilbert [:jgilbert]]

Looks good for my testcase:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=53afd023f96cbb4dd0a6f5f62617e0261c19f814

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8846208 [details]
Bug 1346442 - Update linux64 asan builds to clang3.9+libgcc4.9.4 -

https://reviewboard.mozilla.org/r/119312/#review121868

You need to update msan.manifest and tsan.manifest too.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8846208 [details]
Bug 1346442 - Update linux64 asan builds to clang3.9+libgcc4.9.4 -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/119312/diff/1-2/

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8846208 [details]
Bug 1346442 - Update linux64 asan builds to clang3.9+libgcc4.9.4 -

https://reviewboard.mozilla.org/r/119312/#review122268

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9883a566c747
Update linux64 asan builds to clang3.9+libgcc4.9.4 - r=glandium

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9883a566c747