1346496 - Thunderbird Reader Pane Toolbar Does not Reflect Current Gtk Theme

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[David Rankin]

Attachment: Attachment 1 - Reader pane toolbar button screenshot

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170301181722

Steps to reproduce:

Simply open Tbird 45.8esr in the default 3-pane (folders, message, reader) config.


Actual results:

The button toolbar for the reader pane (bottom right pane of the normal 3-pane setup) toolbar buttons (e.g. Reply, Reply List, Forward, Archive, Junk, Delete, more..) do not reflect the current theme and look awkward. It appears in the version race forward, someone replaced the traditionally defined toolbar with a GtkBuildable xml list and failed to provide a hook to style the toolbar buttons with the current theme. (See Attachment 1 [details] [diff]) This causes the toolbar to look horribly awkward in an otherwise well designed and themed application.


Expected results:

The toolbar buttons should reflect the current theme and button style. This does not occur. As you can see in attachment 1 [details] [diff] [review], the toolbar buttons are an awkward off-white in an otherwise dark theme, but the menus they access are properly styled with the current theme. This mismatch of theme elements should be fixed.

Comment 1

[Jorg K (CEST = GMT+2)]

TB 45 is coming to the end of its life-cycle, TB 52 will be released next week. In the meantime, can you please try with TB 52 beta: https://www.mozilla.org/en-US/thunderbird/channel/

Comment 2

[Richard Marti (:Paenglab)]

That's by design. We don't use the system buttons because, especially on Linux, every theme has his own button height and different border width. BTW. the buttons in the main toolbar use the same styling, except the borders in normal state.

But yes, the borders are too light.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug1346496.patch

This patch makes the msgHeaderView-button's border in normal state less prominent by reducing the opacity.

Comment 4

[:aceman]

Comment on attachment 8846288 [details] [diff] [review]
Bug1346496.patch

Review of attachment 8846288 [details] [diff] [review]:
-----------------------------------------------------------------

I see no difference with the default (white/gray) theme so that must be a good sign:) As I read the patch it just tweaks some transparency so it will become visible when blended with a darker background that will shine through more.

Thanks.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: headrbuttons with patch

This is how the buttons look with patch applied.

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/cbf7af49eabc6fa153cf7d0da1bc3fd74d689b1b

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 8846288 [details] [diff] [review]
Bug1346496.patch

[Approval Request Comment]
User impact if declined: too prominent header button border with dark themes
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

The patch applies on aurora and beta with a fuzziness of one line. For ESR I attach a adapted patch because 52 has still the XP rules.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug1346496-ESR.patch

[Approval Request Comment]
User impact if declined: too prominent header button border with dark themes
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Jorg K (CEST = GMT+2)]

Aurora (TB 54):
https://hg.mozilla.org/releases/comm-aurora/rev/4924f4bdd777fdeb59fff28fff31ab7800ee246b

Beta (TB 53):
https://hg.mozilla.org/releases/comm-beta/rev/4c11c1e4d185b31ec596d49542b93207beae9bdd

Please check that the beta apply worked as intended since there were some minor problems applying the patch.

Comment 10

[Richard Marti (:Paenglab)]

The beta changeset looks good to me.

Comment 11

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/ce2a38b113a1b08feede1829a39fc591c3bd2eb1