js/jsd and extensions/inspector/build/src are now getting built as shareables, even in a static build. Problem is, XPCOM shareables have to have the NsGetModule entry point, and these two don't. Its because XPCOM_TRANSLATE_NSGM_ENTRY_POINT is defined, and it looks like is coming from config.mk: http://lxr.mozilla.org/seamonkey/source/config/config.mk#368 We might be able to fix this by NOT defining MODULE_NAME (set at the bottom of the two Makefiles in question). But I have no idea if this is the RIGHT fix.
Setting a few fields appropriately.
NOT defining MODULE_NAME is js/jsd/Makefile.in and extensions/inspector/build/src/Makefile,in did fix the problem. Had to manually remove the two entries from final-link-comp-names and rebuild nsStaticComponents.cpp, of course. Is this the right fix, Chris?
Yes, unsetting MODULE_NAME should do the trick. The entries should have been removed from comp-link-names when the change to comment out EXPORT_LIBRARY, bug 134012, landed.
Created attachment 77077 [details] [diff] [review] Patch Removes definition of MODULE_NAME from js/jsd and extensions/inspector/build/src Makefile.in's.
Comment on attachment 77077 [details] [diff] [review] Patch r=cls
Comment on attachment 77077 [details] [diff] [review] Patch sr=dveditz
Comment on attachment 77077 [details] [diff] [review] Patch a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Checked in. Checking in js/jsd/Makefile.in; /cvsroot/mozilla/js/jsd/Makefile.in,v <-- Makefile.in new revision: 1.22; previous revision: 1.21 done Checking in extensions/inspector/build/src/Makefile.in; /cvsroot/mozilla/extensions/inspector/build/src/Makefile.in,v <-- Makefile.in new revision: 1.29; previous revision: 1.28 done
Resolving, marking fixed.
verified checked in