If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

static build fails in js/jsd and extensions/inspector/build/src

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
Build Config
--
blocker
VERIFIED FIXED
16 years ago
13 years ago

People

(Reporter: Colin Blake, Assigned: cls)

Tracking

Trunk
mozilla1.0
DEC
OpenVMS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

987 bytes, patch
hacker formerly known as seawood@netscape.com
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
js/jsd and extensions/inspector/build/src are now getting built as shareables, 
even in a static build. Problem is, XPCOM shareables have to have the 
NsGetModule entry point, and these two don't.

Its because XPCOM_TRANSLATE_NSGM_ENTRY_POINT is defined, and it looks like is 
coming from config.mk:
http://lxr.mozilla.org/seamonkey/source/config/config.mk#368

We might be able to fix this by NOT defining MODULE_NAME (set at the bottom of 
the two Makefiles in question). But I have no idea if this is the RIGHT fix.
(Reporter)

Comment 1

16 years ago
Setting a few fields appropriately.
Severity: normal → blocker
OS: Windows 98 → OpenVMS
Hardware: PC → DEC
Target Milestone: --- → mozilla1.0
(Reporter)

Comment 2

16 years ago
NOT defining MODULE_NAME is js/jsd/Makefile.in and
extensions/inspector/build/src/Makefile,in did fix the problem. Had to manually
remove the two entries from final-link-comp-names and rebuild
nsStaticComponents.cpp, of course.

Is this the right fix, Chris?
Yes, unsetting MODULE_NAME should do the trick.  The entries should have been
removed from comp-link-names when the change to comment out EXPORT_LIBRARY, bug
134012, landed.
(Reporter)

Comment 4

16 years ago
Created attachment 77077 [details] [diff] [review]
Patch

Removes definition of MODULE_NAME from js/jsd and
extensions/inspector/build/src Makefile.in's.
Comment on attachment 77077 [details] [diff] [review]
Patch

r=cls
Attachment #77077 - Flags: review+
Comment on attachment 77077 [details] [diff] [review]
Patch

sr=dveditz
Attachment #77077 - Flags: superreview+

Comment 7

16 years ago
Comment on attachment 77077 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77077 - Flags: approval+
(Reporter)

Comment 8

16 years ago
Checked in.

Checking in js/jsd/Makefile.in;
/cvsroot/mozilla/js/jsd/Makefile.in,v  <--  Makefile.in
new revision: 1.22; previous revision: 1.21
done
Checking in extensions/inspector/build/src/Makefile.in;
/cvsroot/mozilla/extensions/inspector/build/src/Makefile.in,v  <--  Makefile.in
new revision: 1.29; previous revision: 1.28
done
(Reporter)

Comment 9

16 years ago
Resolving, marking fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
verified checked in
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.