1346534 - C-C TB build on try-comm-central: use of "-p linux64-valgrind" to create valgrind-friendly version fails (hung?)

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[ISHIKAWA, Chiaki]

Hi,

I would like to CREATE a valgrind-friendly version of C-C TB on try-comm-central.

I tried a few things and got stuck with using "-p linux64-valgrind" literally.

(I had tried to modify build/mozconfig.common by adding
ac_add_options -enable-valgrind, and ac_add_options --disable-jemalloc 
to both build/mozconfig.common AND mozilla/build/mozconfig.common 
but then the build failed because the header files for valgrind is missing.
See https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e02c725272401d05b92c1e4fff8d4627714514b9

But when I realized that there is "-p valgrind-linux64" and tried it try-comm-central, the job got stuck literally.
I cannot even cancel it although the GUI says the job is cancelled (probably because it is in a very strange state.)

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e02c725272401d05b92c1e4fff8d4627714514b9

So I would like to see try-comm-central configuration changed:


I. Add valgrind-related headers (and libraries, but I am not sure about libraries), [this probably allows me to create valgrind-friendly version), 
[this should make it possible to create a valgrind-friendly version and test it without running valgrind when one modifies the two build/mozconfig.common like I did.], and

II. whatever it  takes to handle -p valgrind-linux64 correctly on try-comm-central so that valgrind-enabled version can be created.

I want only to CREATE valgrind-friendly binary: I am not interested in TESTING the binary under valgrind
on the server since it takes a long time and |make mozmill| fails a lot if we don't extend the timeout to a very large value: I have modified the timeout values locally in a successful manner, but still there are some timeout that really need to be extended to a very large value and this may get the test to execute more than 24 hours definitely (my local test take 23 hours, and a few directories are not tested at all since some network connection now fails due to timeout.). So I am reluctant to ask for such a change on try-comm-central.
|make xpcshell-test| works very well since it has an option to run test under valgrind and it seems to handle the timeout value on its own.
Obviously  |make mozmill| lags behind |mach| in this regard.

Anyway, 
S being able to create a valgrind-friendly version on a visible try-comm-central is very important. Someone who is interested in such a binary for local testing can download it from try-comm-central.

BTW, I wonder whoever can do so will cancel my job:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=30000a3b30dea9f2d510065bda46eb007ae95737