1346550 - Can't push review request after attempting to request review from somebody who had it blocked

Status: RESOLVED WONTFIX

(MozReview Graveyard :: Integration: Git, enhancement)

Description

[Andrew McCreight [:mccr8]]

I had r=somebody in my patch, then tried to push and request a review and got a message like this:

commit message for fe1767696b49 has r=somebody but they have not granted a ship-it. review will be requested on your behalf

I selected yes, and then it was rejected, because "somebody" is not accepting review requests. Fine.

I decided I just wanted to put the patch up on the bug anyways, so I removed the r=somebody from my commit message, and tried to do mozreview push again. This time it did NOT have the "review will be requested on your behalf" message, as I would expect.

I then got the "publish these review requests now (Yn)?" again, and I selected Y, but I again got the error message about how "somebody" is not accepting review requests. It should have instead attached the patch to the bug without producing an error.

I tried deleting the MozReview-Commit-ID from the commit message to get a new one, but that did not change the behavior.

If I changed the reviewer to another person, then I was able to successfully post the patch to the bug.

Comment 1

[Piotr Zalewa [:zalun]]

Replicated locally in test env with `hg commit --amend -m "message (bug 1)"`

Comment 2

[Piotr Zalewa [:zalun]]

MozReview is still trying to add a flag after removing the requestee from commit message.

$ hg commit --amend -m 'Bug 1 - Foo modified 1'
$ hg push -y

In `pylib/mozreview/mozreview/bugzilla/client.py#150` `params` contains:

    'flags': [{u'status': u'?', u'requestee': u'[e-mail]', u'name': u'review', u'new': True}]

Comment 3

[Piotr Zalewa [:zalun]]

MozReview is designed like this to not override the list of reviewers added in UI.
To solve the issue one needs to:

  1. open the draft review request in UI (URL is provided in the push message)
  2. remove the reviewer from the list
  3. publish the draft from UI