1346573 - Spotlight Search still shows history sites even after Clear Private Data

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Rick]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170303022339

Steps to reproduce:

STR:
1. In Firefox (non-private tab), search for 'zebra' from address bar
2. Clear Private Data (all items checked) and exit Firefox
3. Pull down the Spotlight Search (SS) panel from top of iOS screen and search for "z"



Actual results:

Actual Result:
There is a Firefox entry for your google search of zebra



Expected results:

Expected: Result:
There should  be no Firefox entry at all

Notes:
The only way it seems to get rid of old Firefox history collected by SS is to uninstall and reinstall Firefox. History from Private Tabs is unrecorded, but there should be a way to clear old data from non-private tabs as well.

Safari and Chrome do not seem to have this problem (although Google's "Google Search" app does), though I'm not certain they even share their history data with SS.

Firefox version 6.1 (1)
iOS version 10.2.1

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2547

Comment 2

[Bryan Munar (:bkmunar)]

Comment on attachment 8849750 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2547

lgtm

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 4

[Justin D'Arcangelo [:justindarc]]

James, is there an issue with this patch we should be aware of before uplifting?

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

uplifted to v7.x

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on 7.3b2743. The only issue with this patch is mentioned in Bug 1356217.

Comment 8

[Rick]

I don't think this is completely fixed yet. When I expand the initial test case and search for several terms (apple, banana, cherry, donut, easy), they don't all disappear from the SS results after one 'Clear Private Data' attempt. Sometimes it takes a couple of attempts, sometimes it takes several before they're all gone (so the results aren't very repeatable). Can anyone else confirm this?

I'm on the released version 7.3 (2772).

Comment 9

[James Hugman [:jhugman] [@jhugman]]

This will likely only be fixed when we can close existing tabs as part of Clear Private Data.