1346582 - Setting an article opened in Reader View as Homepage is not working

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Adrian Oniga]

Steps to reproduce:

1.Open Firefox
2.Go to bbc.com
3.Open an article in Reader View
4.Tap on the Homepage icon
5.Tap Set as Homepage from the opened modal


Actual results:

2.Bbc.com is displayed
3.Selected article is opened in Reader View
4.Modal is displayed
5.Modal is dismissed without any indication that the page was set as Homepage. You can repeat step 4,5 as many times as you want without it setting the Homepage


Expected results:

5.Something should be set as a Homepage (either the original URL or the Reader view URL should be set as Homepage)


If i Go to Settings-Homepage---The Homepage field is empty

Found on iPhone 6, iOS 10.2.1, Firefox version 8.0(1), buddybuild #2039

Comment 1

[Catalin Suciu [:csuciu]]

The issue here is that, when viewing an internal URL, the Home button is not disabled when it is placed in the toolbar. 

When placed in the Menu, the button behaves correctly.

Comment 2

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2550

Comment 3

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2550

Brian, I updated as per your suggestions.

I also have a test-case. But, I'm unable to run test cases on Xcode. I haven't seen this behavior before. When I run HomePageUITest.testSetInternalURLAsHomepage(), it builds alright, then tries running on the simulator, and fails reporting the following error:

Test target XCUITests encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted)

Wondering if others are seeing this issue or if it's just me. I have Xcode 8.2.1 running on macOS 10.11.5 (El Capitan).

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8850830 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2550

I'm not working on Firefox for iOS anymore, so I don't have insight on the current state of tests. Perhaps try asking around in IRC #mobile?

Comment 5

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2550

Comment 6

[Maurya Talisetti]

review ping

Comment 7

[:garvan]

> Test target XCUITests encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted)

This nonsense error is related to provisioning -at least when it has happened to me.

Comment 8

[Maurya Talisetti]

Garvan, I no longer have that error. So, you can ignore my Comment 3. I was able to run my tests and submitted a PR as well, which you seemed to have already commented upon on Github. I'll reply to that on github itself.