1346587 - Add a check for rootNode in getGrids

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

console.error:
  Message: TypeError: rootNode is null
  Stack:
    getAllGrids@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/layout.js:125:7
onNavigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/layout.js:137:17
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
_navigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/tab.js:1321:5
DebuggerProgressListener.prototype.onStateChange<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/tab.js:1665:9
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1346587 - Add a check for rootNode in getGrids.

Review commit: https://reviewboard.mozilla.org/r/119434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119434/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8846374 [details]
Bug 1346587 - Add a check for rootNode in getGrids.

https://reviewboard.mozilla.org/r/119434/#review121498

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9edf963b227e
Add a check for rootNode in getGrids. r=jdescottes

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9edf963b227e