Closed Bug 1346587 Opened 7 years ago Closed 7 years ago

Add a check for rootNode in getGrids

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

console.error:
  Message: TypeError: rootNode is null
  Stack:
    getAllGrids@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/layout.js:125:7
onNavigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/layout.js:137:17
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
_navigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/tab.js:1321:5
DebuggerProgressListener.prototype.onStateChange<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/tab.js:1665:9
exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
Blocks: dt-grid
Summary: Add a check for rootNull in getAllGrids → Add a check for rootNull in getGrids
Summary: Add a check for rootNull in getGrids → Add a check for rootNode in getGrids
Comment on attachment 8846374 [details]
Bug 1346587 - Add a check for rootNode in getGrids.

https://reviewboard.mozilla.org/r/119434/#review121498
Attachment #8846374 - Flags: review?(jdescottes) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9edf963b227e
Add a check for rootNode in getGrids. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/9edf963b227e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: