1346698 - Duplicated l10n strings landed in bug 1333602

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Francesco Lodolo [:flod]]

Bug 1333602 introduced a duplicated string sourceSearch.search in debugger.properties, and this is causing one of our localization tools to misbehave.

https://hg.mozilla.org/releases/mozilla-aurora/file/default/devtools/client/locales/en-US/debugger.properties#l388

# LOCALIZATION NOTE (sourceSearch.search): The center pane Source Search
# prompt for searching for files.
sourceSearch.search=Search Sources…

# LOCALIZATION NOTE (sourceSearch.search): The center pane Source Search
# prompt for searching for files.
# Used in the old debugger fronted
sourceSearch.search=Search…

I assume we should keep the first at this point.

Comment 1

[Jason Laster [:jlast]]

Attachment: fix-duplicate-locale.patch

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8851047 [details] [diff] [review]
fix-duplicate-locale.patch

Review of attachment 8851047 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a bit confused between this patch (which removes the duplicate) and the PR on GitHub that renames one of the two.

Both solve the problem, but I would need to understand why the different approach on two different repos.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eebc7de24c7
Remove duplicated l10n strings landed in bug 1333602. r=flod

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7eebc7de24c7

Comment 5

[Francesco Lodolo [:flod]]

I realized we should have probably removed the other one. When the last version of debugger will land on m-c, sourceSearch.search will switch back to "Search…", and a new sourceSearch.search2 ("Search sources…") will land.
https://github.com/devtools-html/debugger.html/pull/2445/files

This has been messy for a few cycles, so nothing blocking, mostly trying to make sense of the changes.