1346700 - [webvtt] Verify the timestamp in cue text.

Status: NEW

(Core :: Audio/Video: Playback, enhancement, P3)

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1346700 - When rendering, verify timestamp node is valid or not.

Review commit: https://reviewboard.mozilla.org/r/122666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122666/

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8849925 [details]
Bug 1346700 - When rendering, verify timestamp node is valid or not.

https://reviewboard.mozilla.org/r/122666/#review125300

::: dom/media/webvtt/vtt.jsm:308
(Diff revision 1)
>    };
>  
>    // Parse content into a document fragment.
> -  function parseContent(window, input, bReturnFrag) {
> +  function parseContent(window, cue, bReturnFrag) {
> +    var input = cue.text;
> +    var validTimeRange = {start: cue.startTime, end: cue.endTime};

Nits : use "let"

::: dom/media/webvtt/vtt.jsm:390
(Diff revision 1)
>      }
>  
> +    // Check the input ts against to validTimeRange[] and also update
> +    // validTimeRange.
> +    function isValidTimestamp(ts) {
> +    dump(validTimeRange["start"]  +" " +ts+ " "+validTimeRange["end"] +"\n");

Remove the dump.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.