Closed Bug 1346733 Opened 8 years ago Closed 6 years ago

Wasm: Remove restrictions and code that were motivated by code patching

Categories

(Core :: JavaScript: WebAssembly, enhancement, P3)

Product:
Core
Component:
JavaScript: WebAssembly
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: lth, Unassigned)

Details

Code patching was removed in bug 1338217 and I don't think we want to bring it back, so let's clean up. Things that we want to remove are: - Duplication of code segments (bug 1338217) and the use of the identity of code segments to map back to context/module (bug 1334504) - Restrictions on valid heap sizes that were motivated by the ARM's compare-shifted-immediate instruction (for bounds checking), start with IsValidBoundsCheckImmediate and IsValidAsmJSHeapLength and work out from there. Not sure yet how these restrictions might be baked into existing specs though.
Priority: -- → P3
Version: 52 Branch → Trunk
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INACTIVE
Status: RESOLVED → REOPENED
Resolution: INACTIVE → ---
Component: JavaScript Engine: JIT → Javascript: Web Assembly

No more dependents, so let's close.

Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.