Update aboutTelemetry.js to async function & await

RESOLVED FIXED in Firefox 55

Status

()

P4
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: flyingrub, Assigned: flyingrub, Mentored)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client] [lang=js])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170227084058
(Assignee)

Updated

2 years ago
Component: Untriaged → Telemetry
Product: Firefox → Toolkit
Good call, thanks for filing!
Mentor: alessio.placitelli, gfritzsche
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Summary: Update aboutTelemetry.js to async fucntion & await → Update aboutTelemetry.js to async function & await
Whiteboard: [measurement:client] [lang=js]
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8846591 - Flags: review?(gfritzsche)
Attachment #8846591 - Flags: review?(alessio.placitelli)
Comment hidden (mozreview-request)
Assignee: nobody → flyinggrub
Comment on attachment 8846591 [details]
Bug 1346739 - Update aboutTelemetry.js to async fucntion & await

I'm leaving this one to Alessio.
Attachment #8846591 - Flags: review?(gfritzsche)
Comment hidden (mozreview-request)
Please ask Alessio/:dexter for review on this.
Flags: needinfo?(flyinggrub)
I'll get to that as soon as possible.
Flags: needinfo?(flyinggrub)
Attachment #8846591 - Flags: review?(gfritzsche)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8846591 [details]
Bug 1346739 - Update aboutTelemetry.js to async fucntion & await

https://reviewboard.mozilla.org/r/119632/#review121926

This looks good, thanks! Please change the commit message as shown below before we can land this.

Also, please do the following tests locally and let me know if they work:

- Build Firefox with your changes
- Run it using ./mach run
- Open the about:telemetry page
- Make sure that the bits you changed still work (e.g. archivied pings are still loaded and displayed)

If you don't have any archived pings, just close Firefox and open it again.

::: commit-message-f9362:2
(Diff revision 3)
> +Bug 1346739 - Update aboutTelemetry.js to async fucntion & await
> +Replaced all Task occurence by an async function

Please leave a blank line before this line.
Attachment #8846591 - Flags: review?(alessio.placitelli) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8846591 - Flags: review?(gfritzsche)
(Assignee)

Comment 10

2 years ago
Everything was working normally when running the build and changing to an archived ping.
I also added a blank line as asked :).

Comment 11

2 years ago
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3cc331de51d8
Update aboutTelemetry.js to async fucntion & await r=Dexter
(In reply to flyingrub from comment #10)
> Everything was working normally when running the build and changing to an
> archived ping.
> I also added a blank line as asked :).

Nice job! I'm landing this for you ;)

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3cc331de51d8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.