Grid inspector icon is displayed even if display: grid is overriden

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Inspector
VERIFIED FIXED
10 months ago
10 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8846633 [details]
grid_icon_overridden.html

If an element has a "display: grid" property overridden by another "display" value, the rule for display: grid still contains the grid icon (and it looks clickable).

It would be nice if we could display the icon as disabled and maybe disabled pointer events on it when the rule is overridden.

(see page in attachement)

Updated

10 months ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Flags: qe-verify+
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8846641 [details]
Bug 1346786 - hide grid highlighter icon if display rule is overridden;

https://reviewboard.mozilla.org/r/119664/#review121522
Attachment #8846641 - Flags: review?(gl) → review+

Comment 3

10 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/036cc7f662d5
hide grid highlighter icon if display rule is overridden;r=gl

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/036cc7f662d5
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified fixed using the latest Nightly 55.0a1 (2017-03-16) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.