1346786 - Grid inspector icon is displayed even if display: grid is overriden

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Julian Descottes [:jdescottes]]

Attachment: grid_icon_overridden.html

If an element has a "display: grid" property overridden by another "display" value, the rule for display: grid still contains the grid icon (and it looks clickable).

It would be nice if we could display the icon as disabled and maybe disabled pointer events on it when the rule is overridden.

(see page in attachement)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1346786 - hide grid highlighter icon if display rule is overridden;

Review commit: https://reviewboard.mozilla.org/r/119664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119664/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8846641 [details]
Bug 1346786 - hide grid highlighter icon if display rule is overridden;

https://reviewboard.mozilla.org/r/119664/#review121522

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/036cc7f662d5
hide grid highlighter icon if display rule is overridden;r=gl

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/036cc7f662d5

Comment 5

[roxleitan]

Verified fixed using the latest Nightly 55.0a1 (2017-03-16) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64