1346832 - ctrlKey, altKey and metaKey of keypress event shouldn't be consumed by widget when it causes inputting character into editor

Status: NEW

(Core :: DOM: Events, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

TextEditor doesn't accept keypress events as inputting character event if ctrlKey, altKey or metaKey is true. By this limitation, widget consumes these state before dispatching eKeyPress event at dispatching it.

TextEditor should refer another new flag at checking if eKeyPress should cause inputting character. And these modifier states should indicate actual state.

FYI: When AltGr is pressed on Windows, both ctrlKey and altKey are true on the other browsers (and also getModifierState("AltGraph") returns true). Gecko sets them false, but getModifierState("AltGraph") works as expected.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=97d7c6b0e531

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1346832 Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this

UIEvent.isChar is not supported by the other browsers and the value isn't initialized any platforms except on macOS. So, the value isn't useful and we have no reason to keep it.

Review commit: https://reviewboard.mozilla.org/r/120564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120564/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Wait, is the patch for some other bug?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8847613 [details]
Bug 1346832 Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this

https://reviewboard.mozilla.org/r/120564/#review123132

Wrong bug number or something?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, right. Sorry. It's for bug 1347073. I'll post it to the correct bug.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Resetting assignee which I don't work on in this several months.