TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_reload.js

RESOLVED FIXED in Thunderbird 55.0

Status

Thunderbird
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 55.0

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Thunderbird-testfailure: X Linux/Mac])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 months ago
First seen Mon Mar 13, 2017, 15:55:58:

https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=cbf7af49eabc6fa153cf7d0da1bc3fd74d689b1b

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_reload.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_reload.js | test_reloading_a_temp_addon - [test_reloading_a_temp_addon : 224] A promise chain failed to handle a rejection: A mutation operation was attempted on a database that did not allow mutations. - rejection date: Mon Mar 13 2017 10:25:20 GMT-0700 (PDT) - stack: _do_main@/builds/slave/test/build/tests/xpcshell/head.js:211:5
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_reload.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_reload.js | test_reloading_a_temp_addon - [test_reloading_a_temp_addon : 224] A promise chain failed to handle a rejection: A mutation operation was attempted on a database that did not allow mutations. - rejection date: Mon Mar 13 2017 10:25:22 GMT-0700 (PDT) - stack: _do_main@/builds/slave/test/build/tests/xpcshell/head.js:211:5

Looks like
Bug 1344590: Part 1 - Handle extension reloads, upgrades, and manager restarts in xpcshell
or
Bug 1344590: Part 4 - Store parsed and normalized extension data in indexedDB
https://hg.mozilla.org/mozilla-central/rev/d580a74eae4e

Kris, another (web?) extension related test that fails in TB, so far strangely only on Linux and Mac.

Could you please advise us here. Should we just disable the test?
Flags: needinfo?(kmaglione+bmo)
(Assignee)

Updated

3 months ago
Blocks: 1346918
(Assignee)

Comment 1

3 months ago
Only fails on Linux and Mac. Also adding NI for Andrew.
Flags: needinfo?(aswan)
Whiteboard: [Thunderbird-testfailure: X all] → [Thunderbird-testfailure: X Linux/Mac]

Comment 2

3 months ago
To state the obvious, this test is passing on mozilla-central so something is different in Thunderbird.  I'm not familiar enough with Thunderbird to know what's different that could be responsible.  This particular test uses webextensions though, if Thunderbird doesn't support webextensions, disabling that test might be your best bet.
Flags: needinfo?(aswan)
(Assignee)

Comment 3

3 months ago
Created attachment 8848397 [details] [diff] [review]
1346916-disable-test-tb.patch

Thanks for your reply. "Best bet" approach ;-)
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Flags: needinfo?(kmaglione+bmo)
Attachment #8848397 - Flags: review?(aswan)

Comment 4

3 months ago
Comment on attachment 8848397 [details] [diff] [review]
1346916-disable-test-tb.patch

Review of attachment 8848397 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine if its what you want to do but this file contains other tests that you may not want to disable, I was thinking you would just disable the webextensions specific test cases inside this file.
Attachment #8848397 - Flags: review?(aswan) → review+
(Assignee)

Comment 5

3 months ago
Created attachment 8849578 [details] [diff] [review]
1346916-skip-test.patch

For the record: I prepared this patch, but for some reason my try run hasn't gone anywhere yet :-(
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=30f49b89af21210e84d7ccf745c566c5b5c220b3
(Assignee)

Comment 6

3 months ago
Created attachment 8849579 [details] [diff] [review]
1346916-skip-test.patch

Oops, wrong patch.
Attachment #8849578 - Attachment is obsolete: true
(Assignee)

Comment 7

3 months ago
Comment on attachment 8849579 [details] [diff] [review]
1346916-skip-test.patch

Thanks for your suggestion, Andrew. I finally managed to get a try run through:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f883d29f1585772b9c13acd8c27bf81fbc0f5e50
You can't see the changeset since that was pushed earlier on a job that never completed due to some infra problems today.

Anyway, this just skips the part of the test that doesn't work.
Attachment #8849579 - Flags: review?(aswan)

Updated

3 months ago
Attachment #8849579 - Flags: review?(aswan) → review+
(Assignee)

Updated

3 months ago
Attachment #8848397 - Attachment is obsolete: true
(Assignee)

Comment 8

3 months ago
Andrew, thanks for the quick review.

===

Hi Tomcat, this needs to be landed on M-C/M-I. I didn't want to move the bug to an M-C product/component, so I'm setting NI so you can pick it up. Thank you in advance.
Flags: needinfo?(cbook)
Keywords: checkin-needed

Comment 9

3 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb0321aaeca4
Skip test_reload.js:test_reloading_a_temp_addon() for Thunderbird. a=aswan
Keywords: checkin-needed
pushed :)
Flags: needinfo?(cbook)

Comment 11

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/eb0321aaeca4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.