Avoid operator= for PickleIterator in IPDL codegen

RESOLVED FIXED in Firefox 55

Status

()

Core
IPC
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
In bug 1345978, billm pointed out that I could do
  PickleIterator msgIter(aMsg);
instead of
  PickleIterator msgIter = PickleIterator(aMsg);
I was just cribbing off of the code created by lower.py. It is simple to make it produce the former instead of the latter.
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8846820 [details]
Bug 1346958 - Eliminate PickleIterator::operator= calls.

https://reviewboard.mozilla.org/r/119824/#review121940
Attachment #8846820 - Flags: review?(kchen) → review+

Comment 3

10 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20045f98a66c
Eliminate PickleIterator::operator= calls. r=kanru

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/20045f98a66c
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.