Closed Bug 1346958 Opened 5 years ago Closed 5 years ago

Avoid operator= for PickleIterator in IPDL codegen

Categories

(Core :: IPC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

In bug 1345978, billm pointed out that I could do
  PickleIterator msgIter(aMsg);
instead of
  PickleIterator msgIter = PickleIterator(aMsg);
I was just cribbing off of the code created by lower.py. It is simple to make it produce the former instead of the latter.
Comment on attachment 8846820 [details]
Bug 1346958 - Eliminate PickleIterator::operator= calls.

https://reviewboard.mozilla.org/r/119824/#review121940
Attachment #8846820 - Flags: review?(kchen) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20045f98a66c
Eliminate PickleIterator::operator= calls. r=kanru
https://hg.mozilla.org/mozilla-central/rev/20045f98a66c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.