1346958 - Avoid operator= for PickleIterator in IPDL codegen

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Andrew McCreight [:mccr8]]

In bug 1345978, billm pointed out that I could do
  PickleIterator msgIter(aMsg);
instead of
  PickleIterator msgIter = PickleIterator(aMsg);
I was just cribbing off of the code created by lower.py. It is simple to make it produce the former instead of the latter.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1346958 - Eliminate PickleIterator::operator= calls.

Review commit: https://reviewboard.mozilla.org/r/119824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119824/

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8846820 [details]
Bug 1346958 - Eliminate PickleIterator::operator= calls.

https://reviewboard.mozilla.org/r/119824/#review121940

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20045f98a66c
Eliminate PickleIterator::operator= calls. r=kanru

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20045f98a66c