1346982 - Only build WebRender DisplayItems for BoxShadowOuter when supported

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ryan Hunt [:rhunt]]

This is so we can flip the pref on for a demo and not have it crash with an assert.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: boxshadow-outer.patch

I essentially just took the bad conditions from the CreateWebRenderCommands function and moved them to a separate function.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8846867 [details] [diff] [review]
boxshadow-outer.patch

Review of attachment 8846867 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +4964,5 @@
> +  nsRect shadowRect = nsCSSRendering::GetShadowRect(borderRect,
> +                                                    nativeTheme,
> +                                                    mFrame);
> +
> +  RectCornerRadii borderRadii;

nit: If we have a border radius at all, return false since we clip incorrectly in WR right now.

Comment 3

[Ryan Hunt [:rhunt]]

Settled on a better title.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/569c7a783e96
Only build WebRender DisplayItems for BoxShadowOuter when supported r=mchang

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/eaa70038e3f0
Fix static bustage and backwards condition r=me

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/569c7a783e96
https://hg.mozilla.org/mozilla-central/rev/eaa70038e3f0