1347000 - False-positive "Sync message not found, it appears to be fixed" on Windows builds

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Most of the sync messages for PDocAccessible do not exist on Windows, so ipdl spews a bunch of error messages telling us to remove their entries. Of course, their existence in sync-messages.ini is perfectly legitimate for other platforms.

Can we preprocess this file or something?

(Yes, I know we avoid it in IPDL proper)

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

They're supposed to be annotated with |platform = win| or something like. Maybe you could instead write |platform = not-win|. The actual value is not checked.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Fix false-positive sync message not found errors on windows builds

MozReview-Commit-ID: 6ZLCJKotqEE

Comment 3

[Eric Rahm [:erahm]]

For reference and ease of reviewing:

There are 120 errors on a recent windows build [1]. I ran this script, fix_errors.sh:

> #!/bin/bash
> sed -i "/\[$2\]/{n;s/$/\nplatform = notwin/}" $1

through xargs:

> cat errors.txt | xargs -n1 fix_errors.sh ipc/ipdl/sync-messages.ini

Which made 120 changes:

> hg qdiff --stat
>  ipc/ipdl/sync-messages.ini |  120 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 120 insertions(+), 0 deletions(-)


[1] https://treeherder.mozilla.org/logviewer.html#?job_id=85372495&repo=mozilla-central&lineNumber=3310-3549

Comment 4

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3b72f3c21dc

Comment 5

[(no longer active)]

Comment on attachment 8849746 [details] [diff] [review]
Fix false-positive sync message not found errors on windows builds

Review of attachment 8849746 [details] [diff] [review]:
-----------------------------------------------------------------

I'd r+ this but the hg hook we have for sync-messages.ini would catch you since I'm not an IPC peer...

Comment 6

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bc91071fb1b

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8849746 [details] [diff] [review]
Fix false-positive sync message not found errors on windows builds

Review of attachment 8849746 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 8

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8631af6d80424703a260191df10e6c5e46b94292
Bug 1347000 - Fix false-positive sync message not found errors on windows builds. r=billm

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8631af6d8042