False-positive "Sync message not found, it appears to be fixed" on Windows builds

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aklotz, Assigned: erahm)

Tracking

Trunk
mozilla55
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Most of the sync messages for PDocAccessible do not exist on Windows, so ipdl spews a bunch of error messages telling us to remove their entries. Of course, their existence in sync-messages.ini is perfectly legitimate for other platforms.

Can we preprocess this file or something?

(Yes, I know we avoid it in IPDL proper)
They're supposed to be annotated with |platform = win| or something like. Maybe you could instead write |platform = not-win|. The actual value is not checked.
(Assignee)

Comment 2

2 years ago
Created attachment 8849746 [details] [diff] [review]
Fix false-positive sync message not found errors on windows builds

MozReview-Commit-ID: 6ZLCJKotqEE
Attachment #8849746 - Flags: review?(wmccloskey)
(Assignee)

Updated

2 years ago
Assignee: nobody → erahm
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
For reference and ease of reviewing:

There are 120 errors on a recent windows build [1]. I ran this script, fix_errors.sh:

> #!/bin/bash
> sed -i "/\[$2\]/{n;s/$/\nplatform = notwin/}" $1

through xargs:

> cat errors.txt | xargs -n1 fix_errors.sh ipc/ipdl/sync-messages.ini

Which made 120 changes:

> hg qdiff --stat
>  ipc/ipdl/sync-messages.ini |  120 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 120 insertions(+), 0 deletions(-)


[1] https://treeherder.mozilla.org/logviewer.html#?job_id=85372495&repo=mozilla-central&lineNumber=3310-3549
(Assignee)

Updated

2 years ago
Blocks: 1349350

Comment 5

2 years ago
Comment on attachment 8849746 [details] [diff] [review]
Fix false-positive sync message not found errors on windows builds

Review of attachment 8849746 [details] [diff] [review]:
-----------------------------------------------------------------

I'd r+ this but the hg hook we have for sync-messages.ini would catch you since I'm not an IPC peer...
Comment on attachment 8849746 [details] [diff] [review]
Fix false-positive sync message not found errors on windows builds

Review of attachment 8849746 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8849746 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 8

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8631af6d80424703a260191df10e6c5e46b94292
Bug 1347000 - Fix false-positive sync message not found errors on windows builds. r=billm

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8631af6d8042
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.