Closed Bug 1347044 Opened 4 years ago Closed 4 years ago

Shrink two gPSMutex thread-locking scopes in platform.cpp

Categories

(Core :: Gecko Profiler, enhancement)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(1 file)

Shrink two gPSMutex thread-locking scopes in platform.cpp
4.91 KB, patch
mstange
: review+
Details | Diff | Splinter Review 
We're getting a deadlock on automation due to calling JS_ParseJSON() in the
profiler with gPSMutex locked.
The most important of these is the one in profiler_get_profile_jsobject().
Currently the JS_ParseJSON() call frequently leads to deadlock, due to
profiler_log() being called within it.
Attachment #8846985 - Flags: review?(mstange)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3390f735714dd71499d19846a6288e3355a32773 shows this fixes the problem. I did 10 runs of the Linux64 debug devtools mochitests and they were all green. Without this fix they were failing ~50% of the time.
Attachment #8846985 - Flags: review?(mstange) → review+
https://hg.mozilla.org/mozilla-central/rev/bf9d1b5e5665
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1350967
Blocks: 1350967
No longer depends on: 1350967
Blocks: 1342306
No longer blocks: 1350967
You need to log in before you can comment on or make changes to this bug.