1347044 - Shrink two gPSMutex thread-locking scopes in platform.cpp

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Nicholas Nethercote [inactive]]

We're getting a deadlock on automation due to calling JS_ParseJSON() in the
profiler with gPSMutex locked.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Shrink two gPSMutex thread-locking scopes in platform.cpp

The most important of these is the one in profiler_get_profile_jsobject().
Currently the JS_ParseJSON() call frequently leads to deadlock, due to
profiler_log() being called within it.

Comment 2

[Nicholas Nethercote [inactive]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3390f735714dd71499d19846a6288e3355a32773 shows this fixes the problem. I did 10 runs of the Linux64 debug devtools mochitests and they were all green. Without this fix they were failing ~50% of the time.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf9d1b5e5665dccc09118909ac221c32ce42508a
Bug 1347044 - Shrink two gPSMutex thread-locking scopes in platform.cpp. r=mstange.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf9d1b5e5665