Closed Bug 1347064 Opened 7 years ago Closed 7 years ago

Convert FindInPageTests UITests to XCUITests

Categories

(Firefox for iOS :: Build & Test, enhancement)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
Other
iOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: isabel_rios, Assigned: isabel_rios)

References

Details

Attachments

(1 file)

pull-request
55 bytes, text/x-github-pull-request
njpark
: review+
Details | Review 
These tests are currently disabled and not running, the idea is to convert them to XCUITests and have them enabled, up and running
Attached file pull-request — 

    
    

    
  
Comment on attachment 8847080 [details] [review]
pull-request

Tests are green on BB, please r? Thanks!

        Attachment #8847080 -
        Flags: review?(npark)

        Attachment #8847080 -
        Flags: review?(fpatel)

    
    

    
  
Comment on attachment 8847080 [details] [review]
pull-request

Ah right, this page could be used for text search. LGTM.

        Attachment #8847080 -
        Flags: review?(npark) → review+

    
  

        Attachment #8847080 -
        Flags: review?(fpatel)

    
    

    
  
This patch is ready to land, just waiting to have this issue Bug 1350889 about BB builds fixed

    
  
Depends on: 1350889

    
    

    
  
Merged. Commit https://github.com/mozilla-mobile/firefox-ios/commit/acdd7a25454fdc0e8d555be6d3afd7c5c1396ba9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: