1347071 - LocaleService.cpp:96:83: error: 'do_GetService' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P2)

Description

[Makoto Kato [:m_kato]]

When building Fennec with ac_add_options --with-intl-api=no, it causes the following build error

 0:02.38 In file included from /mozilla/objdir-android/intl/locale/Unified_cpp_intl_locale0.cpp:11:0:
 0:02.38 /mozilla/mobile/intl/locale/LocaleService.cpp: In member function 'bool mozilla::intl::LocaleService::GetRequestedLocales(nsTArray<nsCString>&)':
 0:02.38 /mozilla/mobile/intl/locale/LocaleService.cpp:96:83: error: 'do_GetService' was not declared in this scope
 0:02.38    nsCOMPtr<nsIPrefBranch> prefs(do_GetService("@mozilla.org/preferences-service;1"));
 0:02.38                                                                                    ^

To begin with, prefs is unused, so we should remove this line.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sorry for that!

The fix is in bug 1346617 which should land today.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #1)
> Sorry for that!
> 
> The fix is in bug 1346617 which should land today.

Thanks.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

This should be fixed now.