1347073 - Get rid of UIEvent.isChar because no other browsers support it

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, UIEvent.isChar isn't initialized properly in each widget except macOS.

Although, we need similar feature in bug 1346832 in native code level, but we don't need this non-standard attribute anymore.

Note that Add-on SDK referred it. However, as I said, the value hasn't been initialized properly. Currently, there is remaining garbage code:
https://dxr.mozilla.org/mozilla-central/rev/f9362554866b327700c7f9b18050d7b7eb3d2b23/addon-sdk/source/lib/sdk/keyboard/hotkeys.js#72
But we can ignore this because it checks the existence of the attribute and the variable isn't referred now.

So, dropping this attribute shouldn't cause any problem except add-ons working only on macOS.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Posted to dev-platform:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/IVcGOOeOThw

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1347073 Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this

UIEvent.isChar is not supported by the other browsers and the value isn't initialized any platforms except on macOS. So, the value isn't useful and we have no reason to keep it.

Review commit: https://reviewboard.mozilla.org/r/121266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121266/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8848363 [details]
Bug 1347073 Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this

https://reviewboard.mozilla.org/r/121266/#review123430

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/916023361969
Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this r=smaug

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/916023361969

Comment 6

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/uievent-ischar-has-been-removed/

Comment 7

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/isChar

https://developer.mozilla.org/en-US/Firefox/Releases/55