Get rid of UIEvent.isChar because no other browsers support it

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({addon-compat, dev-doc-complete, site-compat})

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Currently, UIEvent.isChar isn't initialized properly in each widget except macOS.

Although, we need similar feature in bug 1346832 in native code level, but we don't need this non-standard attribute anymore.

Note that Add-on SDK referred it. However, as I said, the value hasn't been initialized properly. Currently, there is remaining garbage code:
https://dxr.mozilla.org/mozilla-central/rev/f9362554866b327700c7f9b18050d7b7eb3d2b23/addon-sdk/source/lib/sdk/keyboard/hotkeys.js#72
But we can ignore this because it checks the existence of the attribute and the variable isn't referred now.

So, dropping this attribute shouldn't cause any problem except add-ons working only on macOS.
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8848363 [details]
Bug 1347073 Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this

https://reviewboard.mozilla.org/r/121266/#review123430
Attachment #8848363 - Flags: review?(bugs) → review+

Comment 4

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/916023361969
Get rid of UIEvent.isChar since it's not initialized properly on most platforms and the other browsers don't support this r=smaug
https://hg.mozilla.org/mozilla-central/rev/916023361969
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.